On 9 September 2010 20:56, Charles Matthew Chen <charlesmc...@gmail.com> wrote: > Sebb, please feel free to clean up warnings, etc. in Sanselan. > There's tons of code clean up that I'd like to do if I ever have time.
OK, thanks. I've now fixed the more obvious warnings. There are still a lot of unthrown Exceptions, but as the remaining ones are part of the public API I did not remove them yet. We should either document them (which prevents the Eclipse warning) or remove them, e.g. when 1.0 is released. Most of the code is infested with tabs (I'll start getting rid of the ones in the test code first). > +1 to have more active committers on Sanselan. > > Charles Matthew > > > On Wed, Sep 8, 2010 at 1:48 PM, Matt Benson <gudnabr...@gmail.com> wrote: >> For my part, I should think the community would be glad for someone in >> addition to Charles to have his hands in sanselan. >> >> -Matt >> >> On Sep 8, 2010, at 11:37 AM, sebb wrote: >> >>> There are quite a few Eclipse warnings in the Sanselan test code. >>> >>> For example, test cases that declare impossible Exceptions. >>> Also potential null pointer exceptions that can be fixed either by: >>> - changing assertTrue(null != value) to assertNotNull(value) >>> - or by explicitly checking for null >>> >>> Any objections if I just fix these? >>> >>> Or should I create a JIRA with patches first? >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>> For additional commands, e-mail: dev-h...@commons.apache.org >>> >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
