On Tue, Aug 17, 2010 at 1:10 PM, Simone Tripodi <simone.trip...@gmail.com> wrote: > Thanks a lot! :) Feel free to contact me whenever you need for clarifications. <snip/>
I just took a quick look and have two comments: (a) Being in sync with trunk - There are a large number of small differences between the trunk and the sandbox code (I glanced through a few, such as @Override markers). My understanding is that the only changes you have made are additions of the annotations packages (both source and test), so I can simply ignore the differences I see in other packages. (b) Code doesn't compile - I tried 'mvn test' with Sun 1.5. Once you can confirm my understanding in (a) and fix (b), I'd be happy to take another look. Thanks. -Rahul > All the best, > Simo > > http://people.apache.org/~simonetripodi/ > http://www.99soft.org/ > > > > On Tue, Aug 17, 2010 at 5:47 PM, Rahul Akolkar <rahul.akol...@gmail.com> > wrote: >> On Tue, Aug 17, 2010 at 4:15 AM, Simone Tripodi >> <simone.trip...@gmail.com> wrote: >>> Hi Rahul, >>> this mail just as a reminder since you told me there was no problem at >>> all on ping you :) Can we plan in a short-therm a review on this? >> <snip/> >> >> Yes, thats no problem at all, sometimes even necessary. I will try to >> get to this within a week. >> >> -Rahul >> >> >>> Thanks in advance, have a nice day, >>> Simo >>> >>> http://people.apache.org/~simonetripodi/ >>> http://www.99soft.org/ >>> >>> >>> >>> On Sat, Jul 31, 2010 at 5:59 PM, Simone Tripodi >>> <simone.trip...@gmail.com> wrote: >>>> ok thanks, please don't forget me :P ;) >>>> have anice conference, >>>> Simo >>>> >>>> http://people.apache.org/~simonetripodi/ >>>> http://www.99soft.org/ >>>> >>>> >>>> >>>> On Sat, Jul 31, 2010 at 5:52 PM, Rahul Akolkar <rahul.akol...@gmail.com> >>>> wrote: >>>>> On Thu, Jul 29, 2010 at 10:49 AM, Simone Tripodi >>>>> <simone.trip...@gmail.com> wrote: >>>>>> Hi all guys, >>>>>> any news on this? >>>>> <snip/> >>>>> >>>>> None from me, plus I am at a conference next week. It is still on my >>>>> list, however! >>>>> >>>>> -Rahul >>>>> >>>>> >>>>>> Simo >>>>>> >>>>>> http://people.apache.org/~simonetripodi/ >>>>>> http://www.99soft.org/ >>>>>> >>>>>> >>>>>> >>>>>> On Fri, Jul 23, 2010 at 3:53 PM, Simone Tripodi >>>>>> <simone.trip...@gmail.com> wrote: >>>>>>> Hi Rahul, >>>>>>> thanks a lot, very appreciated :) >>>>>>> Have a nice WE, greetings, >>>>>>> Simo >>>>>>> >>>>>>> http://people.apache.org/~simonetripodi/ >>>>>>> http://www.99soft.org/ >>>>>>> >>>>>>> >>>>>>> >>>>>>> On Fri, Jul 23, 2010 at 4:43 AM, Rahul Akolkar >>>>>>> <rahul.akol...@gmail.com> wrote: >>>>>>>> On Wed, Jul 21, 2010 at 4:01 PM, Simone Tripodi >>>>>>>> <simone.trip...@gmail.com> wrote: >>>>>>>>> Hi all guys, >>>>>>>>> as discussed and agreed with Rahul[1] last week, I added the missing - >>>>>>>>> hopefully, detailed - package documentation on the "annotations" >>>>>>>>> package on the sandbox digester[2] and merged latest trunk >>>>>>>>> modifications, re-executed tests that still pass. >>>>>>>>> Now I'd ask your help/feedbacks/suggestions on promoting that code on >>>>>>>>> /trunk since I'm not (yet, hopefully) a commons committer. >>>>>>>> <snip/> >>>>>>>> >>>>>>>> Thanks, I hope to be able to take a look in a week or two. >>>>>>>> >>>>>>>> There is no need to CC me on these posts, I read the dev list email >>>>>>>> (most of it anyway :-) >>>>>>>> >>>>>>>> -Rahul >>>>>>>> >>>>>>>> >>>>>>>>> Have a nice day, greetings >>>>>>>>> Simo >>>>>>>>> >>>>>>>>> [1] http://markmail.org/message/qwfe4emjf23noilb >>>>>>>>> [2] https://svn.apache.org/repos/asf/commons/sandbox/at-digester/trunk >>>>>>>>> >>>>>>>>> http://people.apache.org/~simonetripodi/ >>>>>>>>> http://www.99soft.org/ >>>>>>>>> >>>>>>>> >>>>> --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
