James, I really like your implementation of the EventListenerSupport class. I think there is still a case for the EventSupport interface and the AbstractEventSupport class, but your EventListenerSupport class definitely deprecates the ReflectiveEventSupport class from LANG-580. I have created a new patch for LANG-580 that changes EventListenerSupport to extend AbstractEventSupport and removes the duplicated methods and the ReflectiveEventSupport class. The test cases still pass, and I believe this meets both of our goals of having a thread-safe event listener framework and a convenient means of firing events.
-Michael On Thu, Jul 22, 2010 at 7:40 AM, James Carman <ja...@carmanconsulting.com> wrote: > All, > > I have committed two new classes into the "event" package in trunk. > > 1. EventListenerSupport - my implementation of an event listener > support class. The idea is that this would replace the > recently-committed stuff from LANG-580. > 2. EventUtils - a static "utils" class which has a couple of useful > event utilities in it (addEventListener and bindEventsToMethod > currently). > > Please have a look. I'd rather not release a beta with the current > event stuff in there if this is going to replace it. > > Thanks, > > James > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
