Thanks for the feedback sebb; comments inline: On Wed, Jul 21, 2010 at 3:58 AM, sebb <seb...@gmail.com> wrote: > On 21 July 2010 01:01, Henri Yandell <flame...@gmail.com> wrote: >> Context: >> >> Releasing a beta version of the Lang 3.0 API for user feedback. >> There aren't any major API changes expected, unless the community >> raises them. The aim would be to _not_ put this in the Maven >> repository. >> >> SVN tag: >> >> http://svn.apache.org/repos/asf/commons/proper/lang/tags/LANG_3_0_B1/ >> > > svn ps svn:eol-style native > src/main/java/org/apache/commons/lang3/CharSequenceUtils.java > svn ps svn:eol-style native > src/test/java/org/apache/commons/lang3/CharSequenceUtilsTest.java > > I could fix this but it would be better if the original author > (ggregory) or at least someone using an OS with the same EOL fixed > the files (in trunk) to reduce commit noise.
Non-blocking, but something to fix. No idea what OS Gary uses :) > What is the licence for the Spring Framework code mentioned in NOTICE? Covered elsewhere in the thread. > The file findbugs-exclude-filter.xml is missing from the source > archive. This seems wrong. Something to fix, I don't see it as blocking for a release as it would only cause pain for someone generating the website. > [The doap is also missing, but that is OK] Agreed. >> Signed downloads: >> >> http://people.apache.org/~bayard/commons-lang-3.0-beta-1/ > > No hashes, but I assume you would add those for a real release. I was expecting to get them and didn't. Easy to create by hand but was odd not to have Maven spitting them out. >> Site: >> >> http://people.apache.org/~bayard/commons-lang-3.0-beta-1/site/ > > Still refers to 2.5 as the current release. Also says that the code is > compatible with Java 1.3. Website, so non-blocking. I'll work on a front page update. >> Note that I've replace the clirr report with a more meaningful one for now: >> >> >> http://people.apache.org/~bayard/commons-lang-3.0-beta-1/site/clirr-report.html >> >> [ ] +1, let's see what people think >> [X] -1, it's not ready yet > > Need to fix the missing file and LICENSE first, plus some other fixes > I just made to trunk. I don't see either of those being blocking. The missing file is minor and the LICENSE doesn't need fixing. > The Javadoc for TypeUtils refers to java.lang.NavigableSet, but that > is @since 1.6. Is that a Javadoc warning rather than fail? Hen --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
