Hadn't ran a test case, so I just now made the following changes to 
ConstructorUtilsTest:

public class ConstructorUtilsTest extends TestCase {
    ...

    public void testGetAccessibleConstructor() throws Exception {
        ...
        assertNull(ConstructorUtils.getAccessibleConstructor(
                NestedPrivateClass.DeeplyNestedClass.class,
                ArrayUtils.EMPTY_CLASS_ARRAY));
    }

    private static class NestedPrivateClass
    {
        public static class DeeplyNestedClass
        {
            public DeeplyNestedClass(){}
        }
    }
}

and it failed.  I'll submit it in JIRA.  It looks like Class.getModfiers() only 
returns the modifiers explicitly declared on the class.





________________________________
From: Henri Yandell <[email protected]>
To: Commons Developers List <[email protected]>
Sent: Sat, March 27, 2010 3:51:44 PM
Subject: Re: [Lang] Question about Accessible Criteria

Interesting question.

I think it should - unless the method Modifier.isPublic method check
checks that already.

Have you tried a test case to see if this would return an invalid constructor?

On Thu, Mar 11, 2010 at 10:10 AM, D Sledge <[email protected]> wrote:
> Looking at the method ConstructorUtils.getAccessibleConstructor(Constructor), 
> I notice that the method checks if the declaring class is public.  Should it 
> not also make sure that the declaring class is either a top-level one or its 
> enclosing class hierarchy are all public, too?
>
> D
>
>
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]


      

Reply via email to