On Wed, Mar 17, 2010 at 12:52 AM, sebb <seb...@gmail.com> wrote: > On 17/03/2010, Niall Pemberton <niall.pember...@gmail.com> wrote: >> I'm -1 to polluting component builds with this. > > I'm only proposing it for Daemon, so the release can be made.
What the vendor id has in the manifest for javadocs and sources jars is trivial. So IMO this is excessive pollution of the build to change (I don't say fix because I don't thinks its an error) one trivial piece of information in those manifests. And IMO it has zero impact on this or any other release. I'm still -1 for this or any other component. Niall > Once commons-parent is fixed, the temporary fix can be removed from Daemon. > >> Niall >> >> 2010/3/16 <s...@apache.org>: >> >> > Author: sebb >> > Date: Tue Mar 16 19:35:12 2010 >> > New Revision: 923946 >> > >> > URL: http://svn.apache.org/viewvc?rev=923946&view=rev >> > Log: >> > Temporary fix for Implementation-Vendor-Id >> > >> > Modified: >> > commons/proper/daemon/trunk/pom.xml >> > >> > Modified: commons/proper/daemon/trunk/pom.xml >> > URL: >> http://svn.apache.org/viewvc/commons/proper/daemon/trunk/pom.xml?rev=923946&r1=923945&r2=923946&view=diff >> > >> ============================================================================== >> > --- commons/proper/daemon/trunk/pom.xml (original) >> > +++ commons/proper/daemon/trunk/pom.xml Tue Mar 16 19:35:12 2010 >> > @@ -126,6 +126,28 @@ >> > <tarLongFileMode>gnu</tarLongFileMode> >> > </configuration> >> > </plugin> >> > + <!-- Temporary fix until commons-parent is updated --> >> > + <plugin> >> > + <artifactId>maven-source-plugin</artifactId> >> > + <configuration> >> > + <archive> >> > + <manifestEntries> >> > + >> <Implementation-Vendor-Id>org.apache</Implementation-Vendor-Id> >> > + </manifestEntries> >> > + </archive> >> > + </configuration> >> > + </plugin> >> > + <!-- Temporary fix until commons-parent is updated --> >> > + <plugin> >> > + <artifactId>maven-javadoc-plugin</artifactId> >> > + <configuration> >> > + <archive> >> > + <manifestEntries> >> > + >> <Implementation-Vendor-Id>org.apache</Implementation-Vendor-Id> >> > + </manifestEntries> >> > + </archive> >> > + </configuration> >> > + </plugin> >> > </plugins> >> > </build> >> > >> > >> > >> > >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
