On 06/01/2010, Phil Steitz <phil.ste...@gmail.com> wrote: > sebb wrote: > > On 05/01/2010, sebb <seb...@gmail.com> wrote: > >> On 05/01/2010, Phil Steitz <phil.ste...@gmail.com> wrote: > >> > sebb wrote: > >> > > It would be very useful to have a Continuum DBCP build that used > Java 5. > >> > > > >> > > The current build uses Java 6 only, so does not test JDBC3 > compatibility. > >> > > > >> > > I don't have Commons Admin on Continuum (and I'm not very familiar > >> > > with it) so please could an Admin add it? > >> > > > >> > > Thanks! > >> > > > >> > > >> > I will look at this tonight. It will have to be done using Ant and > >> > maybe a little scripting, which I am not sure continuum will support. > >> > >> > >> Thanks! > >> > >> If it proves difficult to use Continuum with Ant, then I could set up > >> a Hudson build instead. > >> > >> > >> > The Ant build in trunk will filter sources in the /build directory > >> > (not changing src/ itself) when it runs under <= 1.5, but it > >> > requires build.properties to be set. > >> > >> > >> IMO the Ant build should default to build.properties.sample if > >> build.properties does not exist, but I know others don't agree ... so > >> one possible solution might be to add a target that uses > >> build.properties.sample; or use a variable for the name > >> "build.properties". > >> > > > > The latter already exists: > > > > ant -Dcomponent-propfile=build.properties.sample ... > > > Still working on this. Will give it another try this eve. > > I am also completing review of last set of changes to tests and > sources. So far, so good. > > Otherwise, are we ready for another RC? >
There may possibly be a problem with assymetric equals() definitions; just looking into it now (there are no tests AFAICT). Also, Javadoc could be improved ... I made a start, but there's rather a lot to do. Not essential for this release. > Phil > > > > >> > The Maven build under <=1.5 requires that the sources be > >> > pre-filtered in the src/ directory. > >> > > >> > I use the Ant build in trunk to test compatibility manually. > >> > > >> > Phil > >> > > > --------------------------------------------------------------------- > >> > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > >> > > For additional commands, e-mail: dev-h...@commons.apache.org > >> > > > >> > > >> > > >> > --------------------------------------------------------------------- > >> > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > >> > For additional commands, e-mail: dev-h...@commons.apache.org > >> > > >> > > >> > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
