Luc Maisonobe a écrit : > Phil Steitz a écrit : >> Hopefully 3 is a charm here - I have cut a third release candidate >> and would like to reopen the release vote based on RC3. As >> previously discussed, the only difference between 1.3 and 1.4 is >> that the 1.3 sources have been filtered to exclude JDBC4 methods.
It also seems findbugs-exclude-filter.xml is not in the source distribution, preventing maven to complete mvn site command. Luc > > I don't know if this is a result from the filtering, but when trying to > compile 1.3 I get these compilation errors: > > /home/luc/commons-dbcp-1.3-src/src/java/org/apache/commons/dbcp/DelegatingConnection.java:[65,7] > org.apache.commons.dbcp.DelegatingConnection is not abstract and does > not override abstract method > createStruct(java.lang.String,java.lang.Object[]) in java.sql.Connection > > /home/luc/commons-dbcp-1.3-src/src/java/org/apache/commons/dbcp/cpdsadapter/PooledConnectionImpl.java:[46,0] > org.apache.commons.dbcp.cpdsadapter.PooledConnectionImpl is not abstract > and does not override abstract method > removeStatementEventListener(javax.sql.StatementEventListener) in > javax.sql.PooledConnection > > /home/luc/commons-dbcp-1.3-src/src/java/org/apache/commons/dbcp/datasources/SharedPoolDataSource.java:[45,7] > org.apache.commons.dbcp.datasources.SharedPoolDataSource is not abstract > and does not override abstract method isWrapperFor(java.lang.Class) in > java.sql.Wrapper > > /home/luc/commons-dbcp-1.3-src/src/java/org/apache/commons/dbcp/DelegatingStatement.java:[46,7] > org.apache.commons.dbcp.DelegatingStatement is not abstract and does not > override abstract method isPoolable() in java.sql.Statement > > /home/luc/commons-dbcp-1.3-src/src/java/org/apache/commons/dbcp/DelegatingPreparedStatement.java:[57,7] > org.apache.commons.dbcp.DelegatingPreparedStatement is not abstract and > does not override abstract method setNClob(int,java.io.Reader) in > java.sql.PreparedStatement > > /home/luc/commons-dbcp-1.3-src/src/java/org/apache/commons/dbcp/PoolablePreparedStatement.java:[41,7] > org.apache.commons.dbcp.PoolablePreparedStatement is not abstract and > does not override abstract method setNClob(int,java.io.Reader) in > java.sql.PreparedStatement > > /home/luc/commons-dbcp-1.3-src/src/java/org/apache/commons/dbcp/PoolingDataSource.java:[45,7] > org.apache.commons.dbcp.PoolingDataSource is not abstract and does not > override abstract method isWrapperFor(java.lang.Class) in java.sql.Wrapper > > /home/luc/commons-dbcp-1.3-src/src/java/org/apache/commons/dbcp/BasicDataSource.java:[53,7] > org.apache.commons.dbcp.BasicDataSource is not abstract and does not > override abstract method isWrapperFor(java.lang.Class) in java.sql.Wrapper > > /home/luc/commons-dbcp-1.3-src/src/java/org/apache/commons/dbcp/PoolingConnection.java:[45,7] > org.apache.commons.dbcp.PoolingConnection is not abstract and does not > override abstract method > createStruct(java.lang.String,java.lang.Object[]) in java.sql.Connection > > /home/luc/commons-dbcp-1.3-src/src/java/org/apache/commons/dbcp/DelegatingResultSet.java:[61,7] > org.apache.commons.dbcp.DelegatingResultSet is not abstract and does not > override abstract method updateNClob(java.lang.String,java.io.Reader) in > java.sql.ResultSet > > /home/luc/commons-dbcp-1.3-src/src/java/org/apache/commons/dbcp/DelegatingCallableStatement.java:[58,7] > org.apache.commons.dbcp.DelegatingCallableStatement is not abstract and > does not override abstract method > setNClob(java.lang.String,java.io.Reader) in java.sql.CallableStatement > > /home/luc/commons-dbcp-1.3-src/src/java/org/apache/commons/dbcp/datasources/PerUserPoolDataSource.java:[52,7] > org.apache.commons.dbcp.datasources.PerUserPoolDataSource is not > abstract and does not override abstract method > isWrapperFor(java.lang.Class) in java.sql.Wrapper > > /home/luc/commons-dbcp-1.3-src/src/java/org/apache/commons/dbcp/PoolableCallableStatement.java:[38,7] > org.apache.commons.dbcp.PoolableCallableStatement is not abstract and > does not override abstract method > setNClob(java.lang.String,java.io.Reader) in java.sql.CallableStatement > > /home/luc/commons-dbcp-1.3-src/src/java/org/apache/commons/dbcp/DelegatingDatabaseMetaData.java:[41,7] > org.apache.commons.dbcp.DelegatingDatabaseMetaData is not abstract and > does not override abstract method > getFunctionColumns(java.lang.String,java.lang.String,java.lang.String,java.lang.String) > in java.sql.DatabaseMetaData > >> Here are the artifacts: >> >> 1.3 (JDBC 3) version: >> http://people.apache.org/~psteitz/dbcp-1.3-rc3 >> http://people.apache.org/~psteitz/dbcp-1.3-rc3/site >> http://people.apache.org/~psteitz/dbcp-1.3-rc3/maven >> http://svn.apache.org/repos/asf/commons/proper/dbcp/tags/DBCP_1_3_RC3/ >> >> 1.4 (JDBC 4) version: >> http://people.apache.org/~psteitz/dbcp-1.4-rc3 >> http://people.apache.org/~psteitz/dbcp-1.4-rc3/site >> http://people.apache.org/~psteitz/dbcp-1.4-rc3/maven >> http://svn.apache.org/repos/asf/commons/proper/dbcp/tags/DBCP_1_4_RC3/ >> >> Release notes (common version, ships with both) >> http://people.apache.org/~psteitz/RELEASE-NOTES.txt >> >> Votes, please. This VOTE will close 30-December 20:30 GMT. >> >> [ ] +1 Proceed with release >> [ ] +0 OK >> [ ] -0 OK, but I would prefer... >> [ ] -1 No, showstopper = ... >> >> Thanks! >> >> Phil >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
