On 23/11/2009, sebb <seb...@gmail.com> wrote: > The JUnit tests produce a lot of output, even if the tests are successful. > > Is there really any need to print stack traces in the following method? > > TestSharedPoolDataSource.PoolTest.run() > > I propose to comment them out. > > Similarly, the test case TestManual.testLogWriter() generates a lot of > output. > It's not clear to me what the test is trying to achieve. > Any ideas? >
Does anyone know what TestAbandonedBasicDataSource.testAbandoned() is trying to test? It seems to be similar to testAbandonedClose() except that it does not close the connections. As far as I can tell it achieves nothing at present, except to print some useless messages on System.err. I propose to remove the printouts (and inline the resulting one-line private methods) OK? --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
