On 13/11/2009, Phil Steitz <phil.ste...@gmail.com> wrote: > sebb wrote: > > On 13/11/2009, Phil Steitz <phil.ste...@gmail.com> wrote: > >> We have found and fixed another pool 1.5 regression (POOL-152) and > >> we would like to cut a patch release including the fix. > >> > >> Release distributions: > >> http://people.apache.org/~psteitz/pool-1.5.4-RC1/ > > > > The .sha1 files use an odd format: > > SHA1(commons-pool-1.5.4-bin.tar.gz)= > f01ba012c4a682b5b12d65129a1795af0e38d9a5 > > is normally > > f01ba012c4a682b5b12d65129a1795af0e38d9a5 commons-pool-1.5.4-bin.tar.gz > > or similar > > > > The .md5 files also use a slightly odd format: > > > > b28811a7a368dabca00ad1859de418a1 commons-pool-1.5.4-bin.tar.gz > > is normally > > b28811a7a368dabca00ad1859de418a1 *commons-pool-1.5.4-bin.tar.gz > > > Do you see this as a showstopper? Does anyone else? The > maven-generated hashes don't even include the filename. >
I voted -0, not -1. > > > >> Maven artifacts: > >> http://people.apache.org/~psteitz/pool-1.5.4-RC1/maven/ > >> > >> Site (not included with distributions, not yet updated to reflect > >> release): > >> http://people.apache.org/~psteitz/pool-1.5.4-RC1/site/ > >> > >> Tag: > >> http://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_1_5_4_RC1/ > > > > Compiler source and target in POM are 1.3, yet PMD targetJdk=1.5. > > Maybe that's necessary; if so, please document in POM (trunk) > > > Can fix that in trunk, but I do not see as showstopper for release. > > > > > The POM contains references to a test package that does not exist > > (pool/composite): > > > > <include>org/apache/commons/pool/composite/TestFifoLender.java</include> > > etc. > > > Will fix in trunk, but here again, do not view as showstopper. It > is harmless from test execution standpoint. Agreed, thus -0 not -1. > > > > > However, ant test works with Java 1.3.1_20 and mvn test works with Java > 1.4. > > > >> Votes, please. This vote will close in 72 hours (02:15:00 16-Nov-09) > >> > >> [ ] +1 release 1.5.4 > >> [ ] -1 no, because... > > > > -0 for reasons mentioned above. > > > >> Thanks! > >> > >> Phil > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > >> For additional commands, e-mail: dev-h...@commons.apache.org > >> > >> > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
