Thanks for the review! 2009/11/4 Dan Fabulich <d...@fabulich.com>: > Julien Aymé wrote: > >> I've submitted a patch for DBUTILS-54 and DBUTILS-57, which can be >> added to the release if someone (Dan? ;-) ) has the time to review >> them. >> >> I'll try to submit a patch for DBUTILS-50 later this evening, but I >> think this will require a little more time and thoughts. >> >> https://issues.apache.org/jira/browse/DBUTILS-54 >> https://issues.apache.org/jira/browse/DBUTILS-57 >> https://issues.apache.org/jira/browse/DBUTILS-50 > > I submitted your patch for DBUTILS-57, but I -1 the patch for DBUTIL-54... > it's just too much complexity for a "Minor" issue.
</snip> I thought so when I wrote the patch for DBUTILS-54. I wasn't completly satisfied with it, since the patch is really long and add too many methods in QueryRunner. Maybe we should rewrite it in another specialized class? Anyway, +1 to leave it open for the moment. > > I think DBUTILS-50 will also be controversial (Liam had argued against it) > so at this point I'd like to move ahead with a release candidate for 1.3. > DBUTILS-54 and DBUTILS-50 can be handled in a later release, IMO. (I'd like > to do the release this week; I've blocked out time during ApacheCon to think > about this.) </snap> I'm totally OK with it, please do. And I also agree with Liam, DBUTILS-50 is really complicated to deal with. I tried to implement it in a simple yet usefull way and I couldn't achieve what I wanted. So +1 to leave it open and fix later. Julien > > -Dan > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
