Hi, On Wed, Oct 28, 2009 at 4:42 AM, David Armstrong <davidarmstrong...@gmail.com> wrote: > The new functionality is a class that copies files, called FileCopier > and some helper classes. This class goes beyond the functionality of > the static methods included in the FileUtils class. It has the > following functionality:
Sounds like an useful addition. Can you file a feature request about this in https://issues.apache.org/jira/browse/IO and attach the code there? It would be easier for us to review the code if you could provide it as a patch against the latest svn trunk. That way it would be clearer what parts you have changed and how. You can get a nicely formatted patch with "svn diff" after you've "svn add"ed all the new files you've created. > The patches I included are pretty minor. For FileUtils.java, I changed > the access for doCopyFile() from private to protected so that > FileCopier could make use of its functionality. For IOUtils.java, I > replaced the multiple closeQuietly() methods with one closeQuietly() > method that takes an object that implements Closeable as its argument. > If these patches are not acceptable, please let me know. The latter change sounds like something that could break binary backwards compatibility. BR, Jukka Zitting --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
