On 27/10/2009, ma...@apache.org <ma...@apache.org> wrote: > Author: markt > Date: Tue Oct 27 13:30:50 2009 > New Revision: 830174 > > URL: http://svn.apache.org/viewvc?rev=830174&view=rev > Log: > Add a test case for DBCP-265 > > Added: > > commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestDelegatingDatabaseMetaData.java > (with props) > > commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TesterDatabaseMetaData.java > (with props) > Modified: > commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestAll.java > > commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TesterConnection.java > > commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TesterResultSet.java > > Modified: > commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestAll.java > URL: > http://svn.apache.org/viewvc/commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestAll.java?rev=830174&r1=830173&r2=830174&view=diff > > ============================================================================== > --- commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestAll.java > (original) > +++ commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestAll.java > Tue Oct 27 13:30:50 2009 > @@ -52,6 +52,7 @@ > suite.addTest(TestBasicDataSourceFactory.suite()); > // TestConnectionPool is abstract > suite.addTest(TestDelegatingConnection.suite()); > + suite.addTest(TestDelegatingDatabaseMetaData.suite()); > suite.addTest(TestDelegatingPreparedStatement.suite()); > suite.addTest(TestDelegatingStatement.suite()); > suite.addTest(TestJndi.suite()); >
Would it not be simpler to drop the TestAll classes? It's very easy for tests to get omitted by mistake. Also, is there any point in having singleton test suites? If certain tests have to be run in a particular order, then a suite is useful, but otherwise they don't really add anything useful as far as I can tell. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
