On Tue, Aug 4, 2009 at 11:42 AM, sebb<seb...@gmail.com> wrote: > On 04/08/2009, sebb <seb...@gmail.com> wrote: >> On 03/08/2009, Rahul Akolkar <rahul.akol...@gmail.com> wrote: >> > On Mon, Aug 3, 2009 at 11:57 AM, sebb<seb...@gmail.com> wrote: >> > > There are some classes and methods which are now deprecated in 2.0. >> > > >> > > However, the deprecated items are still used by much of the test code. >> > > >> > > Seems to me that the test cases ought not to use deprecated classes >> > > and methods unless the test is actually for testing the item. >> > > >> > > Any views on this? >> > > >> > >> > <snip/> >> > >> > Sure makes sense to remove usage in tests. One step further, given >> > that a major release is one of the few occassions we can actually do >> > this, we can look at removing some deprecated methods and classes >> > altogether if it helps clean things up and gets us a cleaner, >> > unambiguous API as a result. >> >> >> +1 > > There are now no references to the deprecated classes and methods in > any of the code. > > I removed the deprecated stuff from the workspace, and "mvn clean > test" works OK. > > So I think we could consider dropping the two classes: > > ExpressionFactory > ScriptFactory > <snip/>
Yes, I'm OK with this since it helps the API -- with a prominent note in RELEASE-NOTES.txt (which we should prepare towards to 2.0 anyway). > and removing the methods: > > JexlEngine.getDefault() <snap/> JexlEngine is @since 2.0 so once the two classes above disappear, this serves no useful purpose and can be promptly removed. > and > Info.getTemplateName() > <snip/> Yup, this can go as well. -Rahul --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
