On 21/07/2009, Rory Winston <rory.wins...@gmail.com> wrote: > Hi folks > > Fix release for the 2.0 branch. > > Binaries/sources etc: > http://people.apache.org/~rwinston/commons-net-2.1-RC1/
There's a pom.asc file, but no .pom nor a pom.md5 commons-net-2.1-SNAPSHOT-bin.tar.bz2.asc fails to validate [commons-net-2.1-SNAPSHOT-bin.tar.bz2.md5 is OK, so I assume the download of commons-net-2.1-SNAPSHOT-bin.tar.bz2 was OK] Likewise for: commons-net-2.1-SNAPSHOT-bin.tar.gz.asc commons-net-2.1-SNAPSHOT-bin.zip.asc commons-net-2.1-SNAPSHOT-javadoc.jar.asc commons-net-2.1-SNAPSHOT-sources.jar.asc commons-net-2.1-SNAPSHOT-src.tar.bz2.asc commons-net-2.1-SNAPSHOT-src.tar.gz.asc commons-net-2.1-SNAPSHOT-src.zip.asc The only sigs which work for me are: commons-net-2.1-SNAPSHOT.jar.asc commons-net-ftp-2.1-SNAPSHOT.jar.asc > Tag: > http://svn.apache.org/viewvc/commons/proper/net/tags/NET_2_1_RC1/ Missing AL header: src/main/java/org/apache/commons/net/nntp/ThreadContainer.java NOTICE.txt has: Copyright 2001-2008 This needs to be updated to -2009. The first year disagrees with inceptionYear in pom.xml - one of these is wrong. "mvn test" shows some warnings: [WARNING] Using platform encoding (Cp1252 actually) to copy filtered resources, i.e. build is platform dependent! The POM needs to specify the encoding. Also, I got the following test failure twice: ------------------------------------------------------------------------------- Test set: org.apache.commons.net.telnet.TelnetClientTest ------------------------------------------------------------------------------- Tests run: 8, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 44.063 sec <<< FAILURE! testSetReaderThread(org.apache.commons.net.telnet.TelnetClientTest) Time elapsed: 5.047 sec <<< FAILURE! junit.framework.AssertionFailedError: Expected negotiation1_ok to be true, got false at junit.framework.Assert.fail(Assert.java:47) at junit.framework.Assert.assertTrue(Assert.java:20) at org.apache.commons.net.telnet.TelnetClientTest.testSetReaderThread(TelnetClientTest.java:828) This does not happen every time. > Fixes: > https://issues.apache.org/jira/secure/IssueNavigator.jspa?reset=true&pid=12310487&fixfor=12313001 > > +1 > +0 > -0 > -1 So -1 from me. > Thanks > -- Rory > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
