On 30/06/2009, sebb <[email protected]> wrote:
> On 30/06/2009, [email protected] <[email protected]> wrote:
> > Author: bayard
> > Date: Tue Jun 30 05:09:01 2009
> > New Revision: 789561
> >
> > URL: http://svn.apache.org/viewvc?rev=789561&view=rev
> > Log:
> > Added todo note
> >
> > Modified:
> >
> commons/proper/lang/trunk/src/java/org/apache/commons/lang/text/translate/EntityArrays.java
> >
> > Modified:
> commons/proper/lang/trunk/src/java/org/apache/commons/lang/text/translate/EntityArrays.java
> > URL:
> http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/java/org/apache/commons/lang/text/translate/EntityArrays.java?rev=789561&r1=789560&r2=789561&view=diff
> >
> ==============================================================================
> > ---
> commons/proper/lang/trunk/src/java/org/apache/commons/lang/text/translate/EntityArrays.java
> (original)
> > +++
> commons/proper/lang/trunk/src/java/org/apache/commons/lang/text/translate/EntityArrays.java
> Tue Jun 30 05:09:01 2009
> > @@ -22,6 +22,7 @@
> > *
> > * @since 3.0
> > */
> > +// TODO: These need to be public - make methods to return them for
> security purposes?
>
>
> These really ought to be private, with public getter, to prevent
> accidental or malicious changes to the entries.
I see you have done just that in a later commit.
Sorry for the noise.
>
> > class EntityArrays {
> >
> > static final String[][] ISO8859_1_ESCAPE = {
> >
> >
> >
>
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
