sebb AT ASF a écrit : > Below is a sample of how we might proceed with the removal of > Serializable from implementations. > > Feedback please!
This is fine to me. Luc > > On 22/05/2009, s...@apache.org <s...@apache.org> wrote: >> Author: sebb >> Date: Fri May 22 12:58:26 2009 >> New Revision: 777501 >> >> URL: http://svn.apache.org/viewvc?rev=777501&view=rev >> Log: >> Move Serializable from interface to implementation >> >> Modified: >> >> commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/CholeskyDecomposition.java >> >> commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/CholeskyDecompositionImpl.java >> >> Modified: >> commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/CholeskyDecomposition.java >> URL: >> http://svn.apache.org/viewvc/commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/CholeskyDecomposition.java?rev=777501&r1=777500&r2=777501&view=diff >> >> ============================================================================== >> --- >> commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/CholeskyDecomposition.java >> (original) >> +++ >> commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/CholeskyDecomposition.java >> Fri May 22 12:58:26 2009 >> @@ -17,8 +17,6 @@ >> >> package org.apache.commons.math.linear.decomposition; >> >> -import java.io.Serializable; >> - >> import org.apache.commons.math.linear.RealMatrix; >> >> /** >> @@ -38,12 +36,14 @@ >> * the returned {...@link DecompositionSolver}.</li> >> * </ul> >> * >> + * No longer Serializable since 3.3 >> + * >> * @see <a >> href="http://mathworld.wolfram.com/CholeskyDecomposition.html";>MathWorld</a> >> * @see <a >> href="http://en.wikipedia.org/wiki/Cholesky_decomposition";>Wikipedia</a> >> * @version $Revision$ $Date$ >> * @since 2.0 >> */ >> -public interface CholeskyDecomposition extends Serializable { >> +public interface CholeskyDecomposition { >> >> /** >> * Returns the matrix L of the decomposition. >> >> Modified: >> commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/CholeskyDecompositionImpl.java >> URL: >> http://svn.apache.org/viewvc/commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/CholeskyDecompositionImpl.java?rev=777501&r1=777500&r2=777501&view=diff >> >> ============================================================================== >> --- >> commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/CholeskyDecompositionImpl.java >> (original) >> +++ >> commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/CholeskyDecompositionImpl.java >> Fri May 22 12:58:26 2009 >> @@ -17,6 +17,8 @@ >> >> package org.apache.commons.math.linear.decomposition; >> >> +import java.io.Serializable; >> + >> import org.apache.commons.math.MathRuntimeException; >> import org.apache.commons.math.linear.InvalidMatrixException; >> import org.apache.commons.math.linear.MatrixUtils; >> @@ -37,7 +39,9 @@ >> * @version $Revision$ $Date$ >> * @since 2.0 >> */ >> -public class CholeskyDecompositionImpl implements CholeskyDecomposition { >> +public class CholeskyDecompositionImpl implements CholeskyDecomposition, >> Serializable { >> + // TODO: Add Serializable documentation >> + // TODO: Check Serializable implementation >> >> /** Serializable version identifier. */ >> private static final long serialVersionUID = -2036131698031167221L; >> >> >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
