On 15/05/2009, Oliver Heger <oliver.he...@oliver-heger.de> wrote: > The artifacts look good, the build works fine with JDK 1.4 and 1.6.
Builds and tests OK for me with 1.4. > I think md5 checksums are required for all artifacts. They are currently > missing. Agreed. Could perhaps add sha1 as well, but not essential No need to re-roll the release; just create the hashes. > The PMD report contains a bunch of errors. Many of which are incorrect, e.g. "Do not start a literal by 0 unless it's an octal value" is reported lots of times; the values are in fact octal. Likewise "Avoid empty catch blocks" - these are deliberate. I think the problem here is the PMD rules need tweaking. > I also ran findbugs and got 32 > errors. None of them seem to be critical, so this is not a blocker. I only get 21 warnings, and most of these are in the test cases. > So +1 for the release. +1 for release, provided that the MD5 hashes are generated. > Oliver > > Christian Grobmeier schrieb: > > > > Hi all, > > > > RC2 is based on SVN revision: 774630 > > > > It includes minor changes on the site, corrects svn properties and > > makes a testcase run on win xp. > > > > Please vote: > > > > Tag: > > > https://svn.apache.org/repos/asf/commons/proper/compress/tags/commons-compress-1.0/ > > > > Site: > > > http://people.apache.org/builds/commons/compress/1.0/RC2/site/index.html > > > > Binaries: > > > http://people.apache.org/builds/commons/compress/1.0/RC2/staged/org/apache/commons/commons-compress/1.0/ > > > > > > [ ] +1 release it > > [ ] +0 go ahead I don't care > > [ ] -1 no, do not release it because > > > > Best regards, > > Christian > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: > dev-unsubscr...@commons.apache.org > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
