Hi again,
sorry for the attachment, but this is my proposed Checkstyle config.
Since codestyle is a very personal discussion (sometimes), I would
like to give you a chance to discuss before I create the attachement.
Additionally, i commented out the $properties in teh file till some
maven guru can help me :-)
Mostly I have taken the same options then [email] has, except that I
prefer to have my braces { on the same level as my method name is (sun
standard).
Any comments?
Best,
Christian
On Tue, Mar 24, 2009 at 8:00 AM, Christian Grobmeier
<grobme...@gmail.com> wrote:
> Hi all,
>
> I just try to figure out how to include a checkstyle.xml in compress.
> I have stolen the configuration file
> from [email] and put it in the root directory. For testing I enabled
> it within eclipse and found out that
> I need to set the following properties, which seem to come out from
> commons-parent. I checked that out and searched, but couldn't find the
> setting of this properties.
>
> Can somebody please explain from where I have to fil these properties?
> If somebody could explain or point me to a document or a mail how I
> use commons-parent, this would be helpful too.
>
> Here are the props:
> <property name="headerFile" value="${checkstyle.header.file}"/>
> <property name="cacheFile" value="${checkstyle.cache.file}"/>
>
> However, checkstyle isn't throwing too much errors, a good sign :-)
>
> Cheers,
> Christian
>
<?xml version="1.0" encoding="UTF-8"?>
<!--
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
<!--
Checkstyle-Configuration: compress
Description: Checkstyle configuration for the Apache Compress project
-->
<!DOCTYPE module PUBLIC "-//Puppy Crawl//DTD Check Configuration 1.2//EN" "http://www.puppycrawl.com/dtds/configuration_1_2.dtd";>
<module name="Checker">
<property name="severity" value="warning"/>
<property name="localeLanguage" value="en"/>
<module name="TreeWalker">
<!--
<property name="cacheFile" value="${checkstyle.cache.file}"/>
-->
<!-- Checks for Headers -->
<!-- See http://checkstyle.sf.net/config_header.html -->
<!--
<module name="Header">
<property name="headerFile" value="${checkstyle.header.file}"/>
</module>
-->
<module name="JavadocMethod">
<property name="allowUndeclaredRTE" value="true"/>
</module>
<module name="JavadocType"/>
<module name="JavadocVariable"/>
<module name="ConstantName"/>
<module name="LocalFinalVariableName"/>
<module name="LocalVariableName"/>
<module name="MemberName"/>
<module name="MethodName"/>
<module name="PackageName"/>
<module name="ParameterName"/>
<module name="StaticVariableName"/>
<module name="TypeName"/>
<module name="AvoidStarImport"/>
<module name="IllegalImport"/>
<module name="RedundantImport"/>
<module name="UnusedImports"/>
<module name="FileLength"/>
<module name="LineLength">
<property name="max" value="120"/>
</module>
<module name="MethodLength"/>
<module name="ParameterNumber"/>
<module name="EmptyForIteratorPad"/>
<module name="NoWhitespaceAfter"/>
<module name="NoWhitespaceBefore"/>
<module name="OperatorWrap"/>
<module name="ParenPad"/>
<module name="TabCharacter"/>
<module name="WhitespaceAfter"/>
<module name="WhitespaceAround"/>
<module name="ModifierOrder"/>
<module name="RedundantModifier"/>
<module name="AvoidNestedBlocks"/>
<module name="EmptyBlock">
<property name="option" value="text"/>
<property name="tokens" value="LITERAL_CATCH"/>
</module>
<module name="LeftCurly"/>
<module name="NeedBraces"/>
<module name="RightCurly">
<property name="option" value="alone"/>
</module>
<module name="CovariantEquals"/>
<module name="DoubleCheckedLocking"/>
<module name="EmptyStatement"/>
<module name="EqualsHashCode"/>
<module name="IllegalInstantiation"/>
<module name="InnerAssignment"/>
<module name="MagicNumber"/>
<module name="MissingSwitchDefault"/>
<module name="RedundantThrows"/>
<module name="SimplifyBooleanExpression"/>
<module name="SimplifyBooleanReturn"/>
<module name="StringLiteralEquality"/>
<module name="SuperClone"/>
<module name="SuperFinalize"/>
<module name="IllegalType"/>
<module name="DeclarationOrder"/>
<module name="ExplicitInitialization"/>
<module name="DefaultComesLast"/>
<module name="FallThrough"/>
<module name="MultipleVariableDeclarations"/>
<module name="UnnecessaryParentheses"/>
<module name="FinalClass"/>
<module name="HideUtilityClassConstructor"/>
<module name="InterfaceIsType"/>
<module name="VisibilityModifier">
<property name="protectedAllowed" value="true"/>
</module>
<module name="ArrayTypeStyle"/>
<module name="GenericIllegalRegexp">
<property name="format" value="\s+$"/>
<property name="message" value="Line has trailing spaces."/>
</module>
<module name="TodoComment"/>
<module name="UpperEll"/>
</module>
<module name="PackageHtml"/>
<module name="NewlineAtEndOfFile"/>
<module name="Translation"/>
</module>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
