1.4 it is then. I cba to deal with duplicated build logic in my old age :) So a pom change, update to latest junit then regenerate dist.
Hen On Tue, Mar 10, 2009 at 11:10 AM, sebb <seb...@gmail.com> wrote: > Duh - ignore that. > > Just noticed that ParserTestCase is an abstract class... > > I used "mvn ant:ant" to create the build file so I could test with 1.3 > and the generated file did not exclude ParserTestCase. > > When it is excluded, the tests complete OK. > > Perhaps there is a case for renaming that class ;-) > > More seriously, if a release targets 1.3, it should include some way > of building and testing the code using 1.3. > > On 10/03/2009, sebb <seb...@gmail.com> wrote: >> That would certainly help with testing... >> >> I tried removing the test case with the Java 1.4 class, and the test >> still fails on Java 1.3.1_20 (Win/XP). >> >> The failure is >> >> Cannot instantiate test case: testSimpleShort >> (java.lang.InstantiationException: >> org.apache.commons.cli.ParserTestCase >> at java.lang.reflect.Constructor.newInstance(Native Method) >> at junit.framework.TestSuite.createTest(TestSuite.java:131) >> at junit.framework.TestSuite.addTestMethod(TestSuite.java:114) >> at junit.framework.TestSuite.<init>(TestSuite.java:75) >> >> This appears to be caused by the setUp() method which creates an >> Options() instance and adds 3 options to it. If the code is changed to >> add only 2 options, the failure does not occur, but of course some of >> the tests fail. Odder yet, adding another option allows setUp() to >> work, but still some tests fail. >> >> Looks like Java 1.3.1_20 or JUnit 3.8.1 or the combination is broken. >> >> Is it worth trying to support 1.3 now? >> >> >> On 10/03/2009, Gary Gregory <ggreg...@seagullsoftware.com> wrote: >> > Why not change the Java req. to Java 1.4 for CLI 1.2? (Hides from flying >> tomatoes.) >> > >> > >> > Gary >> > >> > >> > -----Original Message----- >> > From: sebb [mailto:seb...@gmail.com] >> > Sent: Tuesday, March 10, 2009 5:45 AM >> > >> > To: Commons Developers List >> > Subject: Re: [VOTE] Release Commons CLI 1.2 (RC5) >> > >> > -1 >> > >> > Will not build on Java 1.3 as java.sql.ParameterMetaData is @since 1.4. >> > >> > So at least the Java source version in the POM needs changing. >> > I've not yet tried testing on Java 1.3 after building on 1.4 >> > >> > Also the site does not appear to mention the minimum Java requirements >> anywhere. >> > >> > BTW, if it is decided to move to Java 1.4 as a minimum, JUnit should >> > be updated to 3.8.2. >> > >> > On 10/03/2009, Gary Gregory <ggreg...@seagullsoftware.com> wrote: >> > > +1 >> > > >> > > Builds and tests on Sun Java 1.6.0_12 on Windows XP SP3. >> > > >> > > >> > > Gary >> > > >> > > >> > > -----Original Message----- >> > > From: Henri Yandell [mailto:flame...@gmail.com] >> > > Sent: Monday, March 09, 2009 6:41 PM >> > > To: Commons Developers List >> > > Subject: [VOTE] Release Commons CLI 1.2 (RC5) >> > > >> > > One more shot :) >> > > >> > > >> > > Tag: >> > > >> > > https://svn.apache.org/repos/asf/commons/proper/cli/tags/cli-1.2-RC5 >> > > >> > > Site remains unchanged: >> > > >> > > http://people.apache.org/~bayard/cli-1.2-rc1 >> > > >> > > Binaries: >> > > >> > > >> http://people.apache.org/builds/commons/cli/1.2/RC5/staged/commons-cli/commons-cli/1.2/ >> > > >> > > [ ] +1 release it >> > > [ ] +0 go ahead I don't care >> > > [ ] -1 no, do not release it because >> > > >> > > --------------------------------------------------------------------- >> > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> > > For additional commands, e-mail: dev-h...@commons.apache.org >> > > >> > > >> > > --------------------------------------------------------------------- >> > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> > > For additional commands, e-mail: dev-h...@commons.apache.org >> > > >> > > >> > >> > --------------------------------------------------------------------- >> > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> > For additional commands, e-mail: dev-h...@commons.apache.org >> > >> > >> > --------------------------------------------------------------------- >> > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> > For additional commands, e-mail: dev-h...@commons.apache.org >> > >> > >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
