> Applied a slightly changed version. See my comments on the issue. > (Essentially I wasn't a big fan of the worker class in this case.)
OK, please feel free to give me your ideas here. I gladly refactor the code now, before it becomes to big. > The implementation does cover the most simple changes but I guess it > can become more complicated than that. Again see the comments on the > issue. > I think we should start writing some testcases for the complex changes > and try to implement them. Yes totally agreed. I will check out your comments tomorow and set up some testcase for this. Cheers + Thanks > > cheers > -- > Torsten > > On Fri, Jan 9, 2009 at 08:20, Christian Grobmeier <grobme...@gmail.com> wrote: >> Hi, >> >> i made a patch of a first idea of the ChangeSet design which has been >> proposed by Torsten. >> https://issues.apache.org/jira/browse/SANDBOX-183 >> >> The testcase fails with the ArOutputStream. Problem here is located in >> the Ar-Implementation. Torsten, >> would be quite cool if you can check this out, I didn't see why this >> is happening. Basically it's telling me that >> the offset and the previous entry lenght doesn match (1 byte >> difference). I guessed its simliar to the ArInputStream Bug a fixed >> earlier today, but it isn't. You may see it quickly since you wrote it >> all :-) >> >> However, I'll gladly accept your review comments on the ChangeSet. I >> tried to keep it as easy as possible, since I don't think there will >> be a lots of new addtions here in the future. >> >> After the ChangeSet is finished, I will improved the testcases and the >> javadoc. That should do for a first version, does it? >> >> Cheers, >> Christian >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
