Hi all,

i looked in depth in some test failure for javaflow and I think some of them are bugs in the test suite and not in the code.

E.g:

1) the class ClassAccess2.java does not have a Continuation.suspend() so it is ok that the caller does not fine a Continuation. Adding a Continuation.suspend before returning fixed the issue.

2) AbstractSimpleTestCase expects the wrong results for the try/catch issue.
2A) testSimpleTryCatchWithoutException expect 3 continuations (note the last assertTrue(c != null)) but this is wrong. When no exception happen the continuations will be 2. 2B) testSimpleTryCatchWithException expect 3 continuations, expect the wrong result on the 3rd and does not complete/test the last continuation.

Am I totally wrong or they are issues in the test suite?
Should I open a JIRA for this and attach a patch?

AFAICT the try/catch test works fine once the testsuite assertions have been corrected, the only failure is on the synchronized-test.

About the synchronized block and the illegal monitor i'm not sure I understand how it should work.. should javaflow keep the lock open during the suspension or tracking the locked objects and try to lock them again on resume?

Stefano

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to