On 15/07/2008, James Ring <[EMAIL PROTECTED]> wrote: > Hey Sebb, > > > On Mon, Jul 14, 2008 at 5:08 AM, sebb <[EMAIL PROTECTED]> wrote: > > The Hex class has a mix of static and instance methods, which is a bit > > confusing. > > > > The class does not have any state at all, so all the methods could be > static. > > > > Perhaps we should consider adding static versions of the instance > > methods (and have the instance methods call these), with a view to > > perhaps deprecating the instance methods at some stage? > > > How about just making the existing methods static? Static analysis > tools like findbugs will probably complain that they are using an > instance rather than the class name to refer to the newly-static > methods, but no big deal. >
Nice idea. Tried it, but I'd not noticed that the instance methods are actually implementations of interfaces, so that isn't allowed. Looks like the mixture will have to remain. I suppose one could add static versions of the interface methods, but not sure it is worth it. Sorry for the noise. > > Views? > > Regards, > James > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
