Phil Steitz wrote:
I think these methods should be named "setData." They have a different contract from "addData" in SimpleRegression, which does not replace observations that have previously been added. If there are no objections, I will make that change.

Yes - It makes sense to be consistent wrt to SimpleRegression. The addData was left to mirror as much as possible the simple case but it is true that the effect is different.

Alternatively, an even more expression name could be "newData" (and "newX/YSampleData" correspondingly in the abstract method) so it's clear that the user is resetting previously set data.

Another alternative is to introduce a clear() method.

My personal preference would probably be for "newData" but any of the 3 options is fine.

Cheers


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to