Some comments:
- I wonder whether it is possible to implement the JNDINodeHandler so
that it directly operates on Context objects. The main reason why I
introduced NodeHandlers was that it would no longer be necessary to
implement specific node classes. This would also be more efficient in
terms of memory usage because there is no need to duplicate the node
structure.
- A minor nit: I would prefer if the node handler returned empty lists
instead of null (e.g. for attributes). This simplifies the code in
AbstractHierarchicalConfiguration. If the node handler returns
Collections.emptyList(), there should not be any performance issues.
- What exactly is the license of the spice JNDI kit? In any case, we
will have to add something to NOTICE.txt if we use it.
Oliver
[EMAIL PROTECTED] schrieb:
Author: ebourg
Date: Sun Apr 13 16:59:38 2008
New Revision: 647641
URL: http://svn.apache.org/viewvc?rev=647641&view=rev
Log:
Reimplemented JNDIConfiguration to make it hierarchical and support write
operations
Merged the two JNDI test cases
Removed:
commons/proper/configuration/branches/configuration2_experimental/src/test/java/org/apache/commons/configuration2/TestJNDIEnvironmentValues.java
Modified:
commons/proper/configuration/branches/configuration2_experimental/pom.xml
commons/proper/configuration/branches/configuration2_experimental/src/main/java/org/apache/commons/configuration2/AbstractHierarchicalConfiguration.java
commons/proper/configuration/branches/configuration2_experimental/src/main/java/org/apache/commons/configuration2/JNDIConfiguration.java
commons/proper/configuration/branches/configuration2_experimental/src/test/java/org/apache/commons/configuration2/MockInitialContextFactory.java
commons/proper/configuration/branches/configuration2_experimental/src/test/java/org/apache/commons/configuration2/TestJNDIConfiguration.java
commons/proper/configuration/branches/configuration2_experimental/xdocs/changes.xml
<snip/>
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
