On 03/04/2008, Matt Benson <[EMAIL PROTECTED]> wrote: > I added checkstyle with a clone from Lang, which is > pretty permissive. It'd be nice since the project is > being revived with all new blood, as it were, if we > could agree on a style that might be a little less > idiosyncratic (IMO anyway) than the current codebase. > I propose the following changes, at least to start > with (my svn diff): > > Index: checkstyle.xml > =================================================================== > --- checkstyle.xml (revision 644344) > +++ checkstyle.xml (working copy) > @@ -39,5 +39,29 @@ > <module name="JavadocMethod"> > <property name="allowUndeclaredRTE" > value="true"/> > </module> > - </module> > + > + <!-- Checks for whitespace > --> > + <!-- See > http://checkstyle.sf.net/config_whitespace.html --> > + <module name="EmptyForIteratorPad"/>
Dunno > + <module name="NoWhitespaceAfter"/> Seems a bit drastic. I think it makes sense to ban WS after some of the tokens mentioned - e.g. DOT - but perhaps not ARRAY_INIT BNOT LNOT. > + <module name="NoWhitespaceBefore"/> OK > + <module name="OperatorWrap"/> OK > + <module name="TabCharacter"/> +1 > + <module name="WhitespaceAfter"/> OK > + <module name="WhitespaceAround"/> ? > + <module name="GenericIllegalRegexp"> > + <property name="format" value="\s+$"/> > + <property name="message" value="Line has > trailing spaces."/> OK > + </module> > + <module name="UpperEll"/> +1 > + <module name="DeclarationOrder" /> OK > + <module name="ModifierOrder" /> OK > + > + </module> > + > </module> > > This triples the error count, perhaps not > surprisingly. :) > Any consensus? > > > -Matt > > > > > ____________________________________________________________________________________ > You rock. That's why Blockbuster's offering you one month of Blockbuster > Total Access, No Cost. > http://tc.deals.yahoo.com/tc/blockbuster/text5.com > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
