On Thu, Feb 21, 2008 at 9:55 PM, Niall Pemberton <[EMAIL PROTECTED]> wrote: > On Thu, Feb 21, 2008 at 8:15 PM, Niall Pemberton > > <[EMAIL PROTECTED]> wrote: > > > On Thu, Feb 21, 2008 at 6:59 PM, James Carman > > <[EMAIL PROTECTED]> wrote: > > > Niall, > > > > > > Should this sort of thing be in the parent pom? > > > > Possibly/probably - every component should have an assembly, but not > > sure if it would mess up doing pom or skin releases which don't.
Thinking about this for commons-parent and commons-sandbox-parent we just just the "release" profile (don't go thru' rc stage) - I've added assembly descriptors for jci and commons-build-plugin - so they only thing remaining is commons-skin - last time we just released directly using the "release" profile - if it requires a release candidate then we can just have a profile for it, in its pom. So I've added this to commons-parent: http://svn.apache.org/viewvc?view=rev&revision=633587 Niall > I just tried adding this to commons parent - and when I try to run > "mvn -Prc install" for commons-parent I get the following error: > > [ERROR] BUILD ERROR > [INFO] Error reading assemblies: No assembly descriptors found. > > Niall > > > > > Niall > > > > > > > > > > > On 2/21/08, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > > > > Author: niallp > > > > Date: Thu Feb 21 09:13:27 2008 > > > > New Revision: 629875 > > > > > > > > URL: http://svn.apache.org/viewvc?rev=629875&view=rev > > > > Log: > > > > Attach assembly to "package" phase in "rc" profile > > > > > > > > Modified: > > > > commons/proper/proxy/branches/proxy-1.0-work/pom.xml > > > > > > > > Modified: commons/proper/proxy/branches/proxy-1.0-work/pom.xml > > > > URL: > http://svn.apache.org/viewvc/commons/proper/proxy/branches/proxy-1.0-work/pom.xml?rev=629875&r1=629874&r2=629875&view=diff > > > > > ============================================================================== > > > > --- commons/proper/proxy/branches/proxy-1.0-work/pom.xml (original) > > > > +++ commons/proper/proxy/branches/proxy-1.0-work/pom.xml Thu Feb 21 > 09:13:27 2008 > > > > @@ -260,4 +260,26 @@ > > > > <maven.compile.source>1.4</maven.compile.source> > > > > <maven.compile.target>1.4</maven.compile.target> > > > > </properties> > > > > + > > > > + <profiles> > > > > + <profile> > > > > + <id>rc</id> > > > > + <build> > > > > + <plugins> > > > > + <plugin> > > > > + > <artifactId>maven-assembly-plugin</artifactId> > > > > + <executions> > > > > + <execution> > > > > + <goals> > > > > + <goal>attached</goal> > > > > + </goals> > > > > + <phase>package</phase> > > > > + </execution> > > > > + </executions> > > > > + </plugin> > > > > + </plugins> > > > > + </build> > > > > + </profile> > > > > + </profiles> > > > > + > > > > </project> > > > > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
