On 03/03/2008, Niall Pemberton <[EMAIL PROTECTED]> wrote: > On Mon, Mar 3, 2008 at 12:06 PM, Oberhuber, Martin > <[EMAIL PROTECTED]> wrote: > > Also, > > > > I see that while commons.net 1.4.1 compiled properly against > > J2SE-1.2, there are build errors in 1.5.0 with J2SE-1.2: > > > > TFTPServer.java > > SocketTimeoutException is unknown in J2SE-1.2 or 1.3 > > > > I think it's a severe regression to require J2SE-1.4 or > > later just because of newly added TFTPServer. People have > > been sticking with commons.net on Java Micro Editions > > especially because of the old J2SE-1.2 compatibility. > > This should NOT be broken with 1.5.0. > > > The JDK source/target options are 1.3 (inherited from commons-parent) > so it should run on JDK 1.3, except for bits that use 1.4 features and > the source/target could be set to 1.2 (adding > maven.compile.source/maven.compile.target properties to the net > pom.xml) which would mean it should on the whole run on 1.2, if not > compile with 1.2. >
ISTR that the TFTPServer is for testing only, so perhaps one way round this would be to exclude it from builds if the JVM does not support it. > > Niall > > > > Cheers, > > -- > > Martin Oberhuber, Senior Member of Technical Staff, Wind River > > Target Management Project Lead, DSDP PMC Member > > http://www.eclipse.org/dsdp/tm > > > > > > > > > -----Original Message----- > > > From: Oberhuber, Martin > > > > > > > Sent: Montag, 03. März 2008 12:57 > > > To: 'Jakarta Commons Developers List'; 'Rory Winston' > > > Subject: RE: [VOTE] Release Commons Net 1.5 > > > > > > Also, I get unit test failures in > > > FTPClientConfigFunctionalTest.testTimeZoneFunctionality() > > > as well as all FTP Windows tests (looks like ftp.wacom.com > > > is down -- should a different Windows FTP Server be added?) > > > > > > Cheers, > > > -- > > > Martin Oberhuber, Senior Member of Technical Staff, Wind River > > > Target Management Project Lead, DSDP PMC Member > > > http://www.eclipse.org/dsdp/tm > > > > > > > > > > > > > -----Original Message----- > > > > From: Oberhuber, Martin > > > > Sent: Montag, 03. März 2008 11:50 > > > > To: 'Jakarta Commons Developers List' > > > > Subject: RE: [VOTE] Release Commons Net 1.5 > > > > > > > > Hi Rory, > > > > > > > > it's great to hear some progress is being made towards a new > > > > commons.net release!!! > > > > > > > > For the 1.5 release candidate, I notice that the binary > > > > JAR now has the examples classes embedded whereas the 1.4 > > > > release did not. Also, some Maven POM stuff is in META-INF. > > > > Is this intentional? > > > > > > > > jar tfv commons-net-1.4.1.jar | awk '{print $8;}' | sort > cn141.txt > > > > jar tfv commons-net-1.5.0*.jar | awk '{print $8;}' | sort > > > > cn150.txt > > > > diff cn150.txt cn141.txt > > > > > > > > 5,39d4 > > > > < META-INF/maven/ > > > > < META-INF/maven/commons-net/ > > > > < META-INF/maven/commons-net/commons-net/ > > > > < META-INF/maven/commons-net/commons-net/pom.properties > > > > < META-INF/maven/commons-net/commons-net/pom.xml > > > > < examples/ > > > > < examples/IOUtil.class > > > > [...] > > > > < examples/tftp.class > > > > < examples/weatherTelnet.class > > > > 97d61 > > > > < org/apache/commons/net/ftp/parser/NetwareFTPEntryParser.class > > > > 179,180d142 > > > > < org/apache/commons/net/tftp/TFTPServer$TFTPTransfer.class > > > > < org/apache/commons/net/tftp/TFTPServer.class > > > > > > > > Also, your Source Package includes some odd files which I > > > > believe should not be part of a release: the "proposal" did > > > > not make it into the binary release, and "src/assembly" has > > > > not been part of 1.4.1: > > > > /propsal/ftp2/ > > > > /src/assembly/ > > > > /src/java/org/apache/commons/net/tftp/ > > > > -! (DIR) > > > > TFTPClient-1.4.1-fix.diff > > > > TFTPClient.java.orig > > > > TFTPClient.java.rej > > > > > > > > > > > > The other thing I'd REALLY consider important especially for a > > > > 1.5.x service release, is a list of changes that were made. > > > > Is such a changelog available anywhere? > > > > > > > > I tried making a source diff, but it throws out ALL files as > > > > different since the copyright headers changed. I think that > > > > the change in copyright terms might also be worth mentioning > > > > in the change log. More changes were indicated due to RCS > > > > Version tags like * @version $Id: .*$ > > > > or * @version $Revision: .*$ > > > > > > > > That being said, I noticed that the following file(s) do *NOT* > > > > carry the new license header in 1.5: > > > > TFTPClient.java > > > > and others e.g. TimeTCPClientTest.java did even carry an > > > > Apache 1.1 license in version 1.4, or no license at all > > > > (AllTests.java). > > > > > > > > Also, is it legally OK to omit the Copyright Years? In 1.4.1, > > > > some files were Copyright 2001-2005 while others (especially > > > > Telnet) were Copyright 2003-2004 while others (FTPParser) > > > > were Copyright 2004 or Copyright 2005. > > > > > > > > In UnixFTPEntryParserTest.java I see that one test case is > > > > commented out, is this intentional? > > > > > > > > In build.xml you still have this, I think it should not be -dev: > > > > <property name="final.name" value="commons-net-1.5.0-dev"> > > > > > > > > I made some semi-automated editing on the source archives, > > > > and came up with following list of files that were changed > > > > for 1.5.0 -- perhaps it helps finding the bugs that were > > > > resolved for 1.5.0, in order to compile a change list: > > > > > > > > diff -r -b > > > > commons-net-1.4.1/src/java/org/apache/commons/net/ftp/FTP.java > > > > diff -r -b > > > > > > > commons-net-1.4.1/src/java/org/apache/commons/net/ftp/FTPClient.java > > > > diff -r -b > > > > commons-net-1.4.1/src/java/org/apache/commons/net/ftp/FTPClien > > > > tConfig.java > > > > diff -r -b > > > > commons-net-1.4.1/src/java/org/apache/commons/net/ftp/parser/D > > > > efaultFTPFileEntryParserFactory.java > > > > diff -r -b > > > > commons-net-1.4.1/src/java/org/apache/commons/net/ftp/parser/F > > > > TPTimestampParserImpl.java > > > > diff -r -b > > > > commons-net-1.4.1/src/java/org/apache/commons/net/ftp/parser/N > > > > TFTPEntryParser.java > > > > Only in > > > > commons-net-1.5.0-SNAPSHOT-src/src/java/org/apache/commons/net > > > > /ftp/parser: NetwareFTPEntryParser.java > > > > diff -r -b > > > > commons-net-1.4.1/src/java/org/apache/commons/net/ftp/parser/U > > > > nixFTPEntryParser.java > > > > diff -r -b > > > > commons-net-1.4.1/src/java/org/apache/commons/net/nntp/Article.java > > > > diff -r -b > > > > commons-net-1.4.1/src/java/org/apache/commons/net/telnet/Telne > > > > tInputStream.java > > > > diff -r -b > > > > commons-net-1.4.1/src/java/org/apache/commons/net/tftp/TFTPCli > > > > ent.java > > > > Only in > > > > commons-net-1.5.0-SNAPSHOT-src/src/java/org/apache/commons/net > > > > /tftp: TFTPServer.java > > > > > > > > Only in commons-net-1.4.1/target: test-classes > > > > Only in commons-net-1.5.0-SNAPSHOT-src: xdocs > > > > > > > > Cheers, > > > > -- > > > > Martin Oberhuber, Senior Member of Technical Staff, Wind River > > > > Target Management Project Lead, DSDP PMC Member > > > > http://www.eclipse.org/dsdp/tm > > > > > > > --------------------------------------------------------------------- > > > > > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
