I would like to understand exactly what performance improvment results from this change - i.e., see some microbenchmarks or other explanation.
Making this protected adds it to the API that we are committing to maintain and I do not want to do this unless it really helps performance. Phil On 2/11/08, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > Author: ggregory > Date: Mon Feb 11 14:34:34 2008 > New Revision: 620651 > > URL: http://svn.apache.org/viewvc?rev=620651&view=rev > Log: > Fix compiler warning: Access to enclosing constructor > GenericKeyedObjectPool.ObjectQueue() is emulated by a synthetic accessor > method. Increasing its visibility will improve your performance > > Modified: > > commons/proper/pool/trunk/src/java/org/apache/commons/pool/impl/GenericKeyedObjectPool.java > > Modified: > commons/proper/pool/trunk/src/java/org/apache/commons/pool/impl/GenericKeyedObjectPool.java > URL: > http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/java/org/apache/commons/pool/impl/GenericKeyedObjectPool.java?rev=620651&r1=620650&r2=620651&view=diff > ============================================================================== > --- > commons/proper/pool/trunk/src/java/org/apache/commons/pool/impl/GenericKeyedObjectPool.java > (original) > +++ > commons/proper/pool/trunk/src/java/org/apache/commons/pool/impl/GenericKeyedObjectPool.java > Mon Feb 11 14:34:34 2008 > @@ -1681,7 +1681,7 @@ > /** > * A "struct" that keeps additional information about the actual queue of > pooled objects. > */ > - private class ObjectQueue { > + protected class ObjectQueue { > private int activeCount = 0; > private final CursorableLinkedList queue = new CursorableLinkedList(); > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
