On 8/17/07, Matt Benson <[EMAIL PROTECTED]> wrote: > > --- Rahul Akolkar <[EMAIL PROTECTED]> wrote: > > > On 8/13/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> > > wrote: > > > Author: mbenson > > > Date: Mon Aug 13 17:06:29 2007 > > > New Revision: 565581 > > > > > > URL: > > http://svn.apache.org/viewvc?view=rev&rev=565581 > > > Log: > > > format > > > > > <snip/> > > > > Thanks for looking at [el], it was about time > > someone stepped up :-) > > > > I feel some of the purely stylistic changes (such as > > this commit) > > should be avoided, as far as possible. Bit more here > > [1]. > > > > -Rahul > > I have tried to compromise by only > modifying those files in which it is my intent to make > further changes.
Two thoughts on this. 1) The EL style is irritating. Dropped braces, 80 width files, empty * lines at the beginning of javadoc, capitalized method names in the parser. I dislike editing it. 2) Non-surgical changes to EL are going to be HUGELY annoying. We're going to want to compare back to the Jakarta Standard Taglib, so we want to be as surgical as possible and not make unnecessary changes. Bugs in one will be in the other, so we're maintaining a dual codebase here. This latter one is crucial I think, so in this case I'm -1 to any refactorings unless they're applied to both sides. Better to just not bother. Hen --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
