Daniel, I think this is a lazy consensus issue and any further discussion can happen on a PR. No vote thread needed.
On Mon, Feb 13, 2023 at 10:45 PM Daniel Salvador <gutoveron...@apache.org> wrote: > I think I messed up with the format of my last email. Here follows the > message in the correct format: > > --- > > Thank you for the replies, guys. > > I agree using frameworks (ORM and/or OOQ) might facilitate CloudStack's > developers' life. Given the complexity of the project and the whole > analysis and discussion necessary, it would require a lot of effort and > time to implement it, as Daan mentioned; we could open a new discussion on > this topic later. > > Regarding the enforcement, we could validate it via GitHub actions, as > Rohit suggested; and add the instructions in our Coding Convention on > Confluence[¹] as well. > > About Wei's suggestion on having all views in a single file, in my opinion, > having a separate file for each "VIEW" rather than all in a single file > would be more organized and facilitate the diff checking and change > tracking, but we can better discuss the pros and cons of each approach. > > --- > > Summarizing what we discussed so far, to improve the database's "VIEW"s > management, we can have two phases: in the first phase, we manage the > "VIEW"s via specific files (or all "VIEW"s in a single file), executing > them after each version upgrade; in a second phase, we could add a > framework to ACS to improve the whole database management. > > Should I open a vote thread for the proposal of the first phase or can I > already open a PR with the POC and we discuss the details there? > > --- > > Best regards, > Daniel Salvador (gutoveronezi) > > [¹]: > https://cwiki.apache.org/confluence/display/CLOUDSTACK/Coding+conventions > > On Mon, Feb 13, 2023 at 6:37 PM Daniel Salvador <gutoveron...@apache.org> > wrote: > > > Thank you for the replies, guys. > >> > >> I agree using frameworks (ORM and/or OOQ) might facilitate CloudStack's > >> developers' life. Given the complexity of the project and the whole > >> analysis and discussion necessary, it would require a lot of effort and > >> time to implement it, as Daan mentioned; we could open a new discussion > on > >> this topic later. > >> > >> Regarding the enforcement, we could validate it via GitHub actions, as > >> Rohit suggested; and add the instructions in our Coding Convention on > >> Confluence[¹] as well. > >> > >> About Wei's suggestion on having all views in a single file, in my > >> opinion, having a separate file for each "VIEW" rather than all in a > single > >> file would be more organized and facilitate the diff checking and change > >> tracking, but we can discuss better the pros and cons of each approach. > >> > >> --- > >> > >> Summarizing what we discussed so far, to improve the database's "VIEW"s > >> management, we can have two phases: in the first phase, we manage the > >> "VIEW"s via specific files (or all "VIEW"s in a single file), executing > >> them after each version upgrade; in a second phase, we could add a > >> framework to ACS to improve the whole database management. > >> > >> Should I open a vote thread for the proposal of the first phase or can I > >> already open a PR with the POC and we discuss the details there? > >> > >> --- > >> > >> Best regards, > >> Daniel Salvador (gutoveronezi) > >> > >> [¹]: > >> > https://cwiki.apache.org/confluence/display/CLOUDSTACK/Coding+conventions > >> > > > -- Daan
