psycofdj commented on a change in pull request #21:
URL: https://github.com/apache/cloudstack-go/pull/21#discussion_r748280278
##########
File path: cloudstack/HostService.go
##########
@@ -357,7 +357,7 @@ type AddBaremetalHostResponse struct {
Jobstatus int
`json:"jobstatus"`
Lastannotated string
`json:"lastannotated"`
Lastpinged string
`json:"lastpinged"`
- Managementserverid string
`json:"managementserverid"`
+ Managementserverid CSLong
`json:"managementserverid"`
Review comment:
I'm not familiar with this construction but from my understanding it
won't work.
- first: [encoding/json
documentation](https://pkg.go.dev/encoding/json#Marshal) states that this tags
use use to tell the library to store the value as a json-encoded string. It
cannot be use to read an json-long as a string
- second: I created a test program on golang's playgournd that shows that,
indeed, this construction wont work. https://play.golang.org/p/iS3FVwp7mik
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
