Daniel - can you explain what are we exactly voting for? I get that your vote thread is primarily about moving to commons-lang3 but it does not explain the plan and logistics, for example what about:
* Creating a utility facade under cloud-api and using that throughout the codebase; or is it find-replace all usage of google's Strings with common-lang3? * Introducing specific checks via checkstyle plugin to enforce developers (https://github.com/apache/cloudstack/tree/main/tools/checkstyle) * Updating the code conventions wiki/docs Regards. ________________________________ From: Pearl d'Silva <pearl.dsi...@shapeblue.com> Sent: Tuesday, September 14, 2021 09:27 To: dev@cloudstack.apache.org <dev@cloudstack.apache.org> Subject: Re: [VOTE] Standard string lib +1. Sounds like a good plan. ________________________________ From: Gabriel Br?scher <gabrasc...@gmail.com> Sent: Monday, September 13, 2021 9:15 PM To: dev <dev@cloudstack.apache.org> Subject: Re: [VOTE] Standard string lib +1 On Mon, Sep 13, 2021, 12:40 Sadi <s...@scclouds.com.br> wrote: > +1 > > Good idea. > > On 13/09/2021 12:02, Daniel Augusto Veronezi Salvador wrote: > > Hi All, > > > > We had a discussion about standardizing the string libs we're using ( > https://lists.apache.org/thread.html/r806cd10b3de645c150e5e0e3d845c5a380a700197143f57f0834d758%40%3Cdev.cloudstack.apache.org%3E > ). > > > > As I proposed, I'm opening this voting thread to see if all are in favor > of using "commons.lang3" as the String standard library and for String > operations not convered on "commons.lang3", we use our StringUtils. Then, > if the vote passes, I will create the PR to address this change in the code > base by removing unnecessary libraries, and changing the code to use > "commons.lang3". > > > > [ ] +1 approve > > [ ] +0 no opinion > > [ ] -1 disapprove (and reason why) > > > > Best regards, > > Daniel > > >
