davidjumani commented on a change in pull request #802:
URL: https://github.com/apache/cloudstack-primate/pull/802#discussion_r504546201



##########
File path: src/store/modules/user.js
##########
@@ -274,6 +274,16 @@ const user = {
           reject(error)
         })
       })
+    },
+    RefreshFeatures ({ commit }) {
+      return new Promise((resolve, reject) => {
+        api('listCapabilities').then(response => {
+          const result = response.listcapabilitiesresponse.capability
+          commit('SET_FEATURES', result)
+        }).catch(error => {

Review comment:
       @Pearl1594 Would not calling resolve after completion cause any issues ? 
(Promise state, GC, etc)
   ```suggestion
             resolve()
           }).catch(error => {
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to