[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #600: VM Wizard: Custom RAM field compute offering

Fri, 21 Aug 2020 05:46:42 -0700 


davidjumani commented on a change in pull request #600:
URL: https://github.com/apache/cloudstack-primate/pull/600#discussion_r474673665



##########
File path: src/views/compute/wizard/ComputeSelection.vue
##########
@@ -21,31 +21,20 @@
       <a-row>
         <a-col :md="colContraned" :lg="colContraned">
           <a-form-item
-            :label="this.$t('label.cpunumber')"
+            :label="$t('label.cpunumber')"
             :validate-status="errors.cpu.status"
             :help="errors.cpu.message">
             <a-row :gutter="12">
-              <a-col :md="10" :lg="10" v-show="isConstrained">
-                <a-slider
-                  :min="minCpu"
-                  :max="maxCpu"
-                  v-model="cpuNumberInputValue"
-                  @change="($event) => updateComputeCpuNumber($event)"
-                />

Review comment:
       @andrijapanicsb would it be a better UX to hide / show the sliders for 
offerings with a range ?
   ![Screenshot from 2020-08-21 
18-14-47](https://user-images.githubusercontent.com/8244774/90892069-4fd5aa80-e3da-11ea-9692-5837826f4971.png)
   ![Screenshot from 2020-08-21 
18-15-23](https://user-images.githubusercontent.com/8244774/90892072-5106d780-e3da-11ea-8f63-8a40d77e34c5.png)
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to