davidjumani commented on a change in pull request #559:
URL: https://github.com/apache/cloudstack-primate/pull/559#discussion_r461497864



##########
File path: src/components/view/ListView.vue
##########
@@ -68,7 +68,7 @@
         <os-logo v-if="record.ostypename" :osName="record.ostypename" 
size="1x" style="margin-right: 5px" />
         <console :resource="record" size="small" style="margin-right: 5px" />
 
-        <span v-if="$route.path.startsWith('/globalsetting')">{{ text }}</span>
+        <span v-if="$route.path.startsWith('/globalsetting')"></span>
         <span v-if="$route.path.startsWith('/alert')">

Review comment:
       @ravening would be better to make this a v-else-if and leave the prior 
line as is since we don't need a link and detail view for each global setting




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to