davidjumani commented on a change in pull request #553:
URL: https://github.com/apache/cloudstack-primate/pull/553#discussion_r460721718
##########
File path: src/views/network/CreateNetwork.vue
##########
@@ -95,8 +95,9 @@ export default {
isAdvancedZoneWithoutSGAvailable () {
for (const i in this.actionZones) {
const zone = this.actionZones[i]
- if (zone.networktype === 'Advanced' && zone.securitygroupsenabled !==
true) {
- return true
+ // Dont display isolated networks for advanced with sg enabled
+ if (zone.networktype === 'Advanced' && zone.securitygroupsenabled ===
true) {
+ return false
Review comment:
Would this break if there are multiple zones and one with SG Enabled ?
##########
File path: src/views/network/CreateNetwork.vue
##########
@@ -95,8 +95,9 @@ export default {
isAdvancedZoneWithoutSGAvailable () {
for (const i in this.actionZones) {
const zone = this.actionZones[i]
- if (zone.networktype === 'Advanced' && zone.securitygroupsenabled !==
true) {
- return true
+ // Dont display isolated networks for advanced with sg enabled
+ if (zone.networktype === 'Advanced' && zone.securitygroupsenabled ===
true) {
+ return false
}
}
return true
Review comment:
return false over here instead ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
