Pearl1594 commented on a change in pull request #533:
URL: https://github.com/apache/cloudstack-primate/pull/533#discussion_r453635216
##########
File path: src/views/network/FirewallRules.vue
##########
@@ -107,17 +107,17 @@
<p class="add-tags__label">{{ $t('label.value') }}</p>
<a-input v-model="newTag.value"></a-input>
</div>
- <a-button type="primary" :disabled="!('createTag' in
$store.getters.apis)" @click="() => handleAddTag()" :loading="addTagLoading">{{
$t('label.add') }}</a-button>
+ <a-button type="primary" :disabled="!('createTags' in
$store.getters.apis)" @click="() => handleAddTag()" :loading="addTagLoading">{{
$t('label.add') }}</a-button>
</div>
<a-divider></a-divider>
<div class="tags-container">
- <div class="tags" v-for="(tag, index) in tags" :key="index">
- <a-tag :key="index" :closable="'deleteTag' in $store.getters.apis"
:afterClose="() => handleDeleteTag(tag)">
+ <template class="tags" v-for="(tag) in tags">
Review comment:
minor: could remove the redundant brackets
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
