[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #373: Adding pvlan option for l2 and fixing passing none for no pvlan type

[GitBox]

rhtyd commented on a change in pull request #373:
URL: https://github.com/apache/cloudstack-primate/pull/373#discussion_r444666360



##########
File path: src/views/network/CreateL2NetworkForm.vue
##########
@@ -164,7 +190,8 @@ export default {
       networkOfferings: [],
       networkOfferingLoading: false,
       selectedNetworkOffering: {},
-      accountVisible: this.isAdminOrDomainAdmin()
+      accountVisible: this.isAdminOrDomainAdmin(),

Review comment:
       @davidjumani did you check against legacy UI if we should show pvlan 
options to domain admins?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org