rhtyd commented on a change in pull request #383:
URL: https://github.com/apache/cloudstack-primate/pull/383#discussion_r437361061
##########
File path: src/locales/en.json
##########
@@ -29,6 +29,7 @@
"inline": "Inline",
"label.about": "About",
"label.about.app": "About CloudStack",
+"label.accept": "Accept",
Review comment:
where is this used @davidjumani ?
##########
File path: src/views/storage/ResizeVolume.vue
##########
@@ -24,7 +24,7 @@
initialValue: selectedDiskOfferingId,
rules: [{ required: true, message: 'Please select an option' }]}]"
:loading="loading"
- :placeholder="$t('label.offering.type')"
+ :placeholder="$t('label.diskoffering.type')"
Review comment:
See the param is `diskofferingid`, so instead of this we can simply call
it `label.diskoffering`
##########
File path: src/locales/en.json
##########
@@ -686,6 +687,7 @@
"label.diskkbsread": "Disk Read (Bytes)",
"label.diskkbswrite": "Disk Write (Bytes)",
"label.diskoffering": "Disk Offering",
+"label.diskoffering.type": "Disk Offering Type",
Review comment:
Not necessary, see comment below around the usage.
##########
File path: src/locales/en.json
##########
@@ -1019,6 +1020,7 @@
"label.iso.id": "ISO ID",
"label.iso.name": "ISO name",
"label.isoid": "ISO",
+"label.isolated": "Isolated",
Review comment:
There is a way to avoid this, will check tomorrow.
##########
File path: src/views/offering/AddNetworkOffering.vue
##########
@@ -273,7 +273,7 @@
<a-form-item :label="$t('label.tags')">
<a-input
v-decorator="['tags', {}]"
- :placeholder="this.$t('label.networktags')"/>
Review comment:
We can simply call it tags - note the :label already uses label.tags.
##########
File path: src/locales/en.json
##########
@@ -1277,6 +1280,7 @@
"label.network.offering.name": "Network Offering Name",
"label.network.offerings": "Network Offerings",
"label.network.service.providers": "Network Service Providers",
+"label.network.tags": "Network Tags",
Review comment:
Not necessary.
##########
File path: src/locales/en.json
##########
@@ -1068,6 +1070,7 @@
"label.kubernetesversionid": "Kubernetes version",
"label.kubernetesversionname": "Kubernetes version",
"label.kvmnetworklabel": "KVM Traffic Label",
+"label.l2": "L2",
Review comment:
same as above
##########
File path: src/locales/en.json
##########
@@ -1426,6 +1432,7 @@
"label.portableipaddress": "Portable IPs",
"label.portforwarding": "Port Forwarding",
"label.powerstate": "Power State",
+"label.preferred": "Prefered",
Review comment:
Where is this used?
##########
File path: src/locales/en.json
##########
@@ -1539,6 +1549,7 @@
"label.region": "Region",
"label.region.details": "Region details",
"label.reinstall.vm": "Reinstall VM",
+"label.reject": "Reject",
Review comment:
check old UI, for add network offering; if reject is used or something
else?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
