rhtyd edited a comment on pull request #320:
URL: 
https://github.com/apache/cloudstack-primate/pull/320#issuecomment-633016957


   Tests should run slightly faster now, 3x faster in my env: (from over 90s)
   ```
    PASS  tests/unit/components/widgets/Status.spec.js
    PASS  tests/unit/components/view/ActionButton.spec.js
    PASS  tests/unit/views/AutogenView.spec.js (14.795s)
   
   =============================== Coverage summary 
===============================
   Statements   : 5.22% ( 570/10914 )
   Branches     : 6.91% ( 346/5005 )
   Functions    : 2.36% ( 86/3639 )
   Lines        : 5.22% ( 566/10849 )
   
================================================================================
   
   Test Suites: 3 passed, 3 total
   Tests:       104 passed, 104 total
   Snapshots:   0 total
   Time:        28.74s
   Ran all test suites.
   ```
   
   @utchoang can you make the following changes:
   - in the `it()` and any `describe()` please use a full human-readable 
sentence to say what your test is doing (instead of short strings are 
`testCase...`)
   - Can you add more one example unit test for a form or tab component in 
`src/views/` path, for example src/views/compute/MigrateWizard.vue (I picked 
smallest by file size)
   - Exclude from coverage: locales
   
   Thanks for the effort, this looks good overall.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to