Li, can you please rebase you PR against 4.13 (it's on master now)?
Thanks Andrija On Thu, 23 Apr 2020 at 11:13, Wido den Hollander <w...@widodh.nl> wrote: > > > On 4/23/20 11:04 AM, Daan Hoogland wrote: > > never mind found it 3959 > > Do you mean: https://github.com/apache/cloudstack/pull/3959 ? > > Wido > > > > > On Thu, Apr 23, 2020 at 11:03 AM Daan Hoogland <daan.hoogl...@gmail.com> > > wrote: > > > >> Jerry, > >> you say you have a PR but point to the issue. Please give me the PR so I > >> can review. It sounds like a blocker indeed and we need to fix this. > >> > >> On Thu, Apr 23, 2020 at 10:45 AM li jerry <div...@hotmail.com> wrote: > >> > >>> Hi Andrija Panic, > >>> we encountered this bug in production > >>> https://github.com/apache/cloudstack/issues/3958 > >>> > >>> > >>> We fixed it through this PR > >>> https://github.com/apache/cloudstack/issues/3958 > >>> > >>> I am not clear how to apply for PR merge, can you merge this patch to > >>> 4.13.1? > >>> > >>> This bug can be reproduced 100% > >>> > >>> I don't want any users in the community to lose data because of this > bug. > >>> > >>> Thank you! > >>> > >>> -----邮件原件----- > >>> 发件人: Andrija Panic <andrija.pa...@gmail.com> > >>> 发送时间: 2020年4月20日 20:14 > >>> 收件人: dev <dev@cloudstack.apache.org>; users < > us...@cloudstack.apache.org> > >>> 主题: [VOTE] Apache CloudStack 4.13.1.0 RC2 > >>> > >>> Hi All, > >>> > >>> I've created a 4.13.1.0 release (RC2), with the following artefacts up > >>> for testing and a vote: > >>> > >>> Git Branch and Commit SH: > >>> > >>> > https://gitbox.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/4.13.1.0-RC20200420T1036 > >>> Commit: b2596a2be494b39ee5730ece7fdd73166612ef85 > >>> > >>> Source release (checksums and signatures are available at the same > >>> location): > >>> https://dist.apache.org/repos/dist/dev/cloudstack/4.13.1.0/ > >>> > >>> PGP release keys (signed using 3DC01AE8): > >>> https://dist.apache.org/repos/dist/release/cloudstack/KEYS > >>> > >>> The vote will be open until Friday 24th April 2020 (72h) > >>> > >>> For sanity in tallying the vote, can PMC members please be sure to > >>> indicate "(binding)" with their vote? > >>> > >>> [ ] +1 approve > >>> [ ] +0 no opinion > >>> [ ] -1 disapprove (and reason why) > >>> > >>> Additional information: > >>> > >>> For users' convenience, I've built packages from > >>> b2596a2be494b39ee5730ece7fdd73166612ef85 and published RC2 repository > >>> here (CentOS 6, CentOS 7 and Debian/generic): > >>> http://packages.shapeblue.com/testing/41310rc2/ > >>> and here (Ubuntu 18.04 specific, thanks to Gabriel): > >>> > >>> > https://download.cloudstack.org/testing/4.13.1.0-RC20200420T1036/ubuntu/bionic/ > >>> > >>> There are no changes to the systemVM templates vs. 4.13.0.0 - please > use > >>> the official ones (systemvmtemplate-4.11.3-*) from > >>> http://download.cloudstack.org/systemvm/4.11/ > >>> > >>> If upgrading from < 4.13.0.0, please use the existing 4.13.0.0 Upgrade > >>> guide here: > >>> http://docs.cloudstack.apache.org/en/latest/upgrading/index.html > >>> If upgrading from 4.13.0.0, simply upgrade the packages as usual. > >>> > >>> Regards, > >>> Andrija > >>> > >> > >> > >> -- > >> Daan > >> > > > > > -- Andrija Panić