rhtyd commented on a change in pull request #272: view: role based routing for
domain, zone in info
URL: https://github.com/apache/cloudstack-primate/pull/272#discussion_r408311093
##########
File path: src/components/view/InfoCard.vue
##########
@@ -419,7 +419,7 @@
<div class="resource-detail-item__label">{{ $t('zone') }}</div>
<div class="resource-detail-item__details">
<a-icon type="global" />
- <router-link v-if="!resource.zoneid.includes(',')" :to="{ path:
'/zone/' + resource.zoneid }">{{ resource.zonename || resource.zoneid
}}</router-link>
+ <router-link v-if="!resource.zoneid.includes(',') &&
this.isAdmin()" :to="{ path: '/zone/' + resource.zoneid }">{{ resource.zonename
|| resource.zoneid }}</router-link>
Review comment:
@shwstppr instead of such role specific checks, we should check if the vue
route is routable at all or not?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
