rhtyd commented on a change in pull request #290: view: notify admin to restart
MS for non-dynamic settings
URL: https://github.com/apache/cloudstack-primate/pull/290#discussion_r408299365
##########
File path: src/components/view/ListView.vue
##########
@@ -266,14 +266,19 @@ export default {
api('updateConfiguration', {
name: record.name,
value: this.editableValue
- }).then(() => {
+ }).then(json => {
this.editableValueKey = null
this.$message.success('Setting Updated: ' + record.name)
- this.$notification.warning({
- message: 'Status',
- description: 'Please restart your management server(s) for your new
settings to take effect.'
- })
+ if (json.updateconfigurationresponse &&
Review comment:
@shwstppr would this work if API doesnot have the isdynamic in the API
response?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
