rhtyd commented on issue #124: offerings: add custom action URL: https://github.com/apache/cloudstack-primate/pull/124#issuecomment-602418477 @shwstppr please address: Compute/service offering: - Write-cache type missing - message notification translation incomplete (check/add in locales/en.json) Disk offering: - Check my changes, cache modes were wrong - message notification translation incomplete (check/add in locales/en.json) VPC offering: - Support service and provider not on same line - have the default values selected? - message notification translation incomplete (check/add in locales/en.json) Network offering: - Several label translation fixes - message notification translation incomplete (check/add in locales/en.json) - Does not work, needs testing/fixing for isolated, shared, l2 types
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
