rhtyd commented on a change in pull request #73: [WIP] Project: Project View and Actions URL: https://github.com/apache/cloudstack-primate/pull/73#discussion_r360397973
########## File path: src/config/router.js ########## @@ -167,7 +167,29 @@ export const asyncRouterMap = [ { path: '/dashboard', name: 'dashboard', - meta: { title: 'Dashboard', keepAlive: true, icon: 'dashboard' }, + meta: { + title: 'Dashboard', + keepAlive: true, + icon: 'dashboard', + tabs: [ + { + name: 'Dashboard', + component: () => import('@/views/dashboard/UsageDashboardChart') + }, + { + name: 'accounts', + show: (record, route, user) => { return record.account === user.account || ['Admin', 'DomainAdmin'].includes(user.roletype) }, + component: () => import('@/views/projects/AccountsTab') + }, + { + name: 'resources', + permission: ['updateResourceLimit'], + args: ['network', 'volume', 'public_ip', 'template', 'user_vm', 'snapshot', 'vpc', 'cpu', 'memory', 'primary_storage', 'secondary_storage'], + show: (record, route, user) => { return ['Admin'].includes(user.roletype) }, + component: () => import('@/views/projects/ResourcesTab.vue') Review comment: Since this is very specific to whether we're in a project view or not; this maybe moved to the dashboard component itself. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services