Thanks Rohit Thanks for moving ahead #3620. I closed #3619 now.
The reason why i would like #3621 and #3622 to see go ahead as well is because the Nuage CS maven repo is publicly hosted and not maintained and for that we decide it to cease to exist. I would like to shut it down by end of the year. To your concern, what I can do instead on 4.11 and 4.12 branch is removing Nuage from the main pom files (the root pom file + the client pom file), without touching any code at all. Whenever then a bigger change is planned anyway, the current PR's can still be considered (by which you will get the clean cut). The 4.12 was an easy port but the 4.11 one was not straight-forward. Let me know what you think. Cheers, Kris On Mon, 7 Oct 2019 at 13:39, Rohit Yadav <rohit.ya...@shapeblue.com> wrote: > Hi Kris, > > Thanks for sending the PRs. Unless any of us are working on a next minor > release of 4.11 and 4.12, the PRs towards 4.11 and 4.12 are not necessary, > also because in minor releases I think we've preferred to avoid any major > changes including addition or removal of features. > > The PR towards 4.13 can be used towards master as we can forward merge > that to master and therefore #3619 may be closed. > I'll help wrt review and testing of #3620. > > > Regards, > > Rohit Yadav > > Software Architect, ShapeBlue > > https://www.shapeblue.com > > ________________________________ > From: Kris Sterckx <kris.ster...@nuagenetworks.net> > Sent: Sunday, October 6, 2019 18:41 > To: dev@cloudstack.apache.org <dev@cloudstack.apache.org> > Subject: Further cleaning up NuageVsp plugin code > > Hi all, > > > Please take a look at following PR's > > https://github.com/apache/cloudstack/pull/3619 (master) > https://github.com/apache/cloudstack/pull/3620 (4.13) > https://github.com/apache/cloudstack/pull/3621 (4.12) > https://github.com/apache/cloudstack/pull/3622 (4.11) > > They proceed with cleanup of NuageVsp plugin (cfr [1]) to the relevant > per-release master branches (+ on 4.13 and master have some additional > minor cleanups). > > I would like these to get merged as i am concerned with the > cs.mv.nuagenetworks.net maven repo, referred to from the Nuage plugin > code, > being no longer maintained and i don't want to break any build going > forward. > > Your collaboration to get this merged is appreciated. > > thanks > > Kris > > [1] https://github.com/apache/cloudstack/pull/3146 > > rohit.ya...@shapeblue.com > www.shapeblue.com > Amadeus House, Floral Street, London WC2E 9DPUK > @shapeblue > > > >
