All,

I want to explore a way to be more transparent with the community on PRs 
especially new features that we're working on (my colleagues and me at 
ShapeBlue), however, like every organization, we have our internal processes 
around development, testing, review and internal validation before a PR is good 
enough to be merged/included in CloudStack. In the past, we've had a few 
situations when an upstream PR sent without a WIP in the title/description or a 
Work-In-Progress label but it was merged since all the smoketests passed OK and 
it has 2 LGTMs from the community members. In all such cases, another PR was 
sent top rectify it but that incurred some overhead in time and energy.


In order to be more transparent, I would like to propose that we put something 
like ' [WIP DO NOT MERGE]' in the PR title as my colleagues and I have done on 
some new PRs you can follow. Labels cannot be used as not every contributor is 
a committer. Once the PR is ready for merging, we can remove it.


This would allow the community:

(a) to be aware that the PR is in progress and should not be merged even if it 
gets all smoketests pass and have at least 2 LGTMs.

(b) presents an opportunity for early conversations, engagements.

(c) avoid duplicate efforts towards features, bugfixes, and blockers and 
encourage joining forces towards a common feature/goal!


I think it would be great if more people can join us in this direction.

Thoughts, concerns? Thanks.


Regards,

Rohit Yadav

Software Architect, ShapeBlue

https://www.shapeblue.com

[email protected] 
www.shapeblue.com
Amadeus House, Floral Street, London  WC2E 9DPUK
@shapeblue
  
 

Reply via email to