Mike, are you able to pin-point in the old/replaced code the bit that was handling your use case? I took the most care not to break anything. Also, your test case, isn't it in the ACS' integration test suite? In theory, all test passed when we merged the PR.
I sure can take a look at it. Can you detail your use case? I mean, the high level execution flow. What API methods you do, what you expected to happen, and what is happening today. On Sun, Jul 15, 2018 at 3:25 AM, Tutkowski, Mike <mike.tutkow...@netapp.com> wrote: > It looks like this is the problematic PR: > > https://github.com/apache/cloudstack/pull/2425/ > > On 7/15/18, 12:20 AM, "Tutkowski, Mike" <mike.tutkow...@netapp.com> wrote: > > Hi, > > While running managed-storage regression tests tonight, I noticed a > problem that is not related to managed storage. > > CLOUDSTACK-10240 is a ticket asking that we allow the migration of a > virtual disk that’s on local storage to shared storage. In the process of > enabling this feature, the VirtualMachineManagerImpl. > getPoolListForVolumesForMigration method was re-written in a way that > completely breaks at least one use case: Migrating a VM across compute > clusters (at least supported in XenServer). If, say, a virtual disk resides > on shared storage in the source compute cluster, we must be able to copy > this virtual disk to shared storage in the destination compute cluster. > > As the code is currently written, this is no longer possible. It also > seems that the managed-storage logic has been dropped for some reason in > the new implementation. > > Rafael – It seems that you worked on this feature. Would you be able > to look into this and create a PR? > > Thanks, > Mike > > > -- Rafael Weingärtner
