yeah, way ahead of you Igor ;) I asked a question about it On Mon, Jan 8, 2018 at 11:05 AM, Voloshanenko Igor < igor.voloshane...@gmail.com> wrote:
> Updates posted to https://github.com/apache/cloudstack/pull/2389 > Can you please review? > > 2018-01-08 11:57 GMT+02:00 Voloshanenko Igor <igor.voloshane...@gmail.com > >: > > > Sure. Got it. > > > > Will post update soon > > > > 2018-01-08 11:38 GMT+02:00 Daan Hoogland <daan.hoogl...@gmail.com>: > > > >> Igor, I remember your PR and think it is fine. It can also be argued > that > >> it needs to go in as a security feature. For an RM it is unthinkably > late, > >> but fortunately it is very small. I will however -1 it if it leads to a > >> plethora of last minute PRs to include. > >> > >> On Mon, Jan 8, 2018 at 10:33 AM, Voloshanenko Igor < > >> igor.voloshane...@gmail.com> wrote: > >> > >> > Guys, can we please include https://github.com/apache/clou > >> dstack/pull/2389 > >> > into 4.11 > >> > PR very small and updates will be published in next few hours. > >> > > >> > As we have this for a while in production for 4.8 branch. > >> > > >> > 2018-01-08 11:15 GMT+02:00 Boris Stoyanov < > boris.stoya...@shapeblue.com > >> >: > >> > > >> > > +1 Daan > >> > > > >> > > > >> > > boris.stoya...@shapeblue.com > >> > > www.shapeblue.com > >> > > 53 Chandos Place, Covent Garden, London WC2N 4HSUK > >> > > @shapeblue > >> > > > >> > > > >> > > > >> > > > On 8 Jan 2018, at 10:47, Daan Hoogland <daan.hoogl...@gmail.com> > >> > wrote: > >> > > > > >> > > > Rohit, Ivan, > >> > > > > >> > > > I think we can argue that the five open PRs on the milestone can > >> still > >> > go > >> > > > in as long as active work on them continues. I have not looked at > >> > Ivan's > >> > > > PRs yet but can see they were entered in december and he is > actively > >> > > > working on it so why not include those in the milestone. A bigger > >> > concern > >> > > > is that some of the remaining PRs in that milestone are > potentially > >> > > > conflicting. So we feature freeze now and work only to get the set > >> list > >> > > in > >> > > > (and blockers). > >> > > > > >> > > > > >> > > > On Mon, Jan 8, 2018 at 9:39 AM, Ivan Kudryavtsev < > >> > > kudryavtsev...@bw-sw.com> > >> > > > wrote: > >> > > > > >> > > >> Rohit, Devs, > >> > > >> > >> > > >> just consider adding: > >> > > >> > >> > > >> CLOUDSTACK-10188 / https://github.com/apache/ > cloudstack/pull/2362 > >> > > [resouce > >> > > >> accounting blocker bug] > >> > > >> CLOUDSTACK-10170 / https://github.com/apache/ > cloudstack/pull/2350 > >> > > >> [security > >> > > >> fix, enchancement] > >> > > >> > >> > > >> They are ready (we think so) for some time, but *no final review* > >> yet. > >> > > >> > >> > > >> > >> > > >> 2018-01-08 14:47 GMT+07:00 Rohit Yadav < > rohit.ya...@shapeblue.com > >> >: > >> > > >> > >> > > >>> All, > >> > > >>> > >> > > >>> > >> > > >>> As per the previously shared schedule [1], by EOD today (8 Jan > >> 2018) > >> > we > >> > > >>> would freeze master after which we'll only accept > critical/blocker > >> > > fixes, > >> > > >>> stabilize master and start a voting thread on 4.11 RC1 (est. by > 15 > >> > Jan > >> > > >>> 2018). > >> > > >>> > >> > > >>> > >> > > >>> I wanted to gather consensus if this is acceptable to everyone > as > >> > there > >> > > >>> are still few outstanding feature PRs that I understand authors > >> have > >> > > >> worked > >> > > >>> hard to get them in. > >> > > >>> > >> > > >>> > >> > > >>> Please share your thoughts, comments. If you're the author of > >> such > >> > an > >> > > >>> existing PR, please work with us, address outstanding issues. > >> > > >>> > >> > > >>> > >> > > >>> In case of no objections, it will be assumed that the plan is > >> > > acceptable > >> > > >>> to everyone. Thanks. > >> > > >>> > >> > > >>> > >> > > >>> [1] http://markmail.org/message/mszlluye35acvn2j > >> > > >>> > >> > > >>> > >> > > >>> - Rohit > >> > > >>> > >> > > >>> <https://cloudstack.apache.org> > >> > > >>> > >> > > >>> > >> > > >>> > >> > > >>> rohit.ya...@shapeblue.com > >> > > >>> www.shapeblue.com > >> > > >>> 53 Chandos Place, Covent Garden, London WC2N 4HSUK > >> > > >>> @shapeblue > >> > > >>> > >> > > >>> > >> > > >>> > >> > > >>> > >> > > >> > >> > > >> > >> > > >> -- > >> > > >> With best regards, Ivan Kudryavtsev > >> > > >> Bitworks Software, Ltd. > >> > > >> Cell: +7-923-414-1515 > >> > > >> WWW: http://bitworks.software/ <http://bw-sw.com/> > >> > > >> > >> > > > > >> > > > > >> > > > > >> > > > -- > >> > > > Daan > >> > > > >> > > > >> > > >> > >> > >> > >> -- > >> Daan > >> > > > > > -- Daan
